Re: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

Ido Yariv
2012-12-21T02:24:30Z

Hi Sjur,

On Fri, Dec 14, 2012 at 05:06:56PM +0100, Sjur Brændeland wrote:
> Postpone the registration of virtio devices until all
> vritio ring resource has been allocated.
> This fixes the following bug: The driver's start callback
> is called before all vring notify ids are allocated and
> max_notifyid will be increased after starting the remoteproc.

It seems that this patch wont solve this issue, since
rproc_add_virtio_dev eventually increases max_notifyid, so the same
problem will simply occur at a later stage.

Also, it seems that the original rproc_add_virtio_dev calls were not
removed, so devices would be added twice.

If max_notifyid needs to be set before the first virtio device is added,
how about counting the number of notification ids in advance before
adding the devices, by traversing the resource list twice?

Thanks,
Ido.