From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Clark Williams <clark.williams@gmail.com>
Subject: [RFC][PATCH 0/2] sched: Allow interrupts to be enabled in idle balance
Date: Fri, 21 Dec 2012 19:30:19 -0500 [thread overview]
Message-ID: <20121222003019.433916240@goodmis.org> (raw)
The idle_balance() code is treated special in the scheduler for
no real apparent reason. There's an unlikely check for !rq->nr_running
in the hot path of the scheduler, for just the idle load balancing.
As sched classes can have their own post schedule routine, and the
idle task has its own scheduler class, we can move the idle_balance()
into the idle task's post schedule routine, and out of the hot path
of the scheduler (no sepecial check).
An added benefit for doing this is that this enables us to enable
interrupts in the idle balance code. Shrinking the time interrupts
are disabled while doing load balancing.
These patches have been thoroughly tested (on a 40 core box as well
as a 4 core and UP config), and are prime for inclusion (for 3.9).
But I'm posted them now as an RFC for comments.
Thanks!
-- Steve
next reply other threads:[~2012-12-22 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 0:30 Steven Rostedt [this message]
2012-12-22 0:30 ` [RFC][PATCH 1/2] sched: Move idle_balance() to post_schedule Steven Rostedt
2012-12-22 1:00 ` Steven Rostedt
2013-01-05 14:14 ` Frederic Weisbecker
2012-12-22 0:30 ` [RFC][PATCH 2/2] sched: Enable interrupts in idle_balance() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121222003019.433916240@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=clark.williams@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox