From: Grant Likely <grant.likely@secretlab.ca>
To: David Cohen <david.a.cohen@intel.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com, "Li,
Ning" <ning.li@intel.com>, David Cohen <david.a.cohen@intel.com>
Subject: Re: [PATCH v2 2/2] gpio-langwell: implement irq shutdown interface
Date: Sat, 22 Dec 2012 10:12:44 +0000 [thread overview]
Message-ID: <20121222101244.6585E3E0AD0@localhost> (raw)
In-Reply-To: <1356043552-14579-3-git-send-email-david.a.cohen@intel.com>
On Thu, 20 Dec 2012 14:45:52 -0800, David Cohen <david.a.cohen@intel.com> wrote:
> From: "Li, Ning" <ning.li@intel.com>
>
> Disable falling/rising edge detection during irq shutdown operation.
Why? (A commit description should also say why a change is needed. Not
just what it does)
g.
>
> Signed-off-by: David Cohen <david.a.cohen@intel.com>
> Signed-off-by: Li, Ning <ning.li@intel.com>
> ---
> drivers/gpio/gpio-langwell.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
> index 2be69fe..10cc520 100644
> --- a/drivers/gpio/gpio-langwell.c
> +++ b/drivers/gpio/gpio-langwell.c
> @@ -225,11 +225,32 @@ static void lnw_irq_mask(struct irq_data *d)
> {
> }
>
> +static void lnw_irq_shutdown(struct irq_data *d)
> +{
> + struct lnw_gpio *lnw = irq_data_get_irq_chip_data(d);
> + u32 gpio = irqd_to_hwirq(d);
> + unsigned long flags;
> + u32 value;
> + void __iomem *grer = gpio_reg(&lnw->chip, gpio, GRER);
> + void __iomem *gfer = gpio_reg(&lnw->chip, gpio, GFER);
> +
> + spin_lock_irqsave(&lnw->lock, flags);
> +
> + /* Disable falling/rising edge detection */
> + value = readl(grer) & ~BIT(gpio % 32);
> + writel(value, grer);
> + value = readl(gfer) & ~BIT(gpio % 32);
> + writel(value, gfer);
> +
> + spin_unlock_irqrestore(&lnw->lock, flags);
> +};
> +
> static struct irq_chip lnw_irqchip = {
> .name = "LNW-GPIO",
> .irq_mask = lnw_irq_mask,
> .irq_unmask = lnw_irq_unmask,
> .irq_set_type = lnw_irq_type,
> + .irq_shutdown = lnw_irq_shutdown,
> };
>
> static DEFINE_PCI_DEVICE_TABLE(lnw_gpio_ids) = { /* pin number */
> --
> 1.7.10.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
prev parent reply other threads:[~2012-12-22 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 22:45 [PATCH v2 0/2] gpio-langwell: update pci device table David Cohen
2012-12-20 22:45 ` [PATCH v2 1/2] gpio-langwell: cleanup driver David Cohen
2012-12-22 10:09 ` Grant Likely
2012-12-20 22:45 ` [PATCH v2 2/2] gpio-langwell: implement irq shutdown interface David Cohen
2012-12-22 10:12 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121222101244.6585E3E0AD0@localhost \
--to=grant.likely@secretlab.ca \
--cc=alan@linux.intel.com \
--cc=david.a.cohen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ning.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).