public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec
Date: Sun, 23 Dec 2012 11:55:28 +0100	[thread overview]
Message-ID: <20121223105527.GA6230@liondog.tnic> (raw)
In-Reply-To: <CADnq5_Oe=_nOrsgUZvPc82F5CFAWecx=Uiqn0CAeK+YG3ns3AA@mail.gmail.com>

On Sat, Dec 22, 2012 at 07:42:16PM -0500, Alex Deucher wrote:
> Does booting with radeon.wb=0 help?

Right, this param specification somehow didn't work here:

[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-3.8.0-rc1 root=/dev/sda1 ro vga=0 log_bug_len=10M resume=/dev/sda2 no_console_suspend ignore_loglevel hpet=force radeon.wb=0
[    0.000000] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.8.0-rc1 root=/dev/sda1 ro vga=0 log_bug_len=10M resume=/dev/sda2 no_console_suspend ignore_loglevel hpet=force radeon.wb=0

[ … ]

[    6.910104] radeon: `0' invalid for parameter `wb'

[ … ]

[   28.191072] radeon: `0' invalid for parameter `wb'

although the whole driver blubber didn't appear on the console fterwards
aso something got turned off allright.

Then, I went and tried "radeon.no_wb" where the driver blubber appeared
but AGP writeback was still enabled:

[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-3.8.0-rc1 root=/dev/sda1 ro vga=0 log_bug_len=10M resume=/dev/sda2 no_console_suspend ignore_loglevel hpet=force radeon.no_wb
[    0.000000] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.8.0-rc1 root=/dev/sda1 ro vga=0 log_bug_len=10M resume=/dev/sda2 no_console_suspend ignore_loglevel hpet=force radeon.no_wb

[ … ]

[    6.382636] [drm] radeon kernel modesetting enabled.
[    6.384915] radeon 0000:02:00.0: VRAM: 512M 0x0000000000000000 - 0x000000001FFFFFFF (512M used)
[    6.384981] radeon 0000:02:00.0: GTT: 512M 0x0000000020000000 - 0x000000003FFFFFFF
[    6.388137] [drm] radeon: 512M of VRAM memory ready
[    6.388181] [drm] radeon: 512M of GTT memory ready.
[    6.388509] radeon 0000:02:00.0: irq 42 for MSI/MSI-X
[    6.388570] radeon 0000:02:00.0: radeon: using MSI.
[    6.388705] [drm] radeon: irq initialized.
[    6.567811] radeon 0000:02:00.0: WB enabled
				    ^^^^^^^^^^

[    6.567856] radeon 0000:02:00.0: fence driver on ring 0 use gpu addr 0x0000000020000c00 and cpu addr 0xffff8802243e5c00
[    6.567922] radeon 0000:02:00.0: fence driver on ring 3 use gpu addr 0x0000000020000c0c and cpu addr 0xffff8802243e5c0c
[    6.601247] [drm] Radeon Display Connectors
[    6.602427] [drm] radeon: power management initialized
[    6.722544] fbcon: radeondrmfb (fb0) is primary device
[    6.945065] radeon 0000:02:00.0: fb0: radeondrmfb frame buffer device
[    6.945100] radeon 0000:02:00.0: registered panic notifier
[    6.945159] [drm] Initialized radeon 2.27.0 20080528 for 0000:02:00.0 on minor 0

At this point, I got tired of this experimenting and went and took the
big hammer :-):

diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index 49b06590001e..00214312db23 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -307,6 +307,11 @@ int radeon_wb_init(struct radeon_device *rdev)
                rdev->wb.use_event = true;
        }
 
+       if (rdev->wb.enabled) {
+               pr_err("%s: disable the goddam WB: radeon_no_wb: %d\n", __func__, radeon_no_wb);
+               rdev->wb.enabled = false;
+       }
+
        dev_info(rdev->dev, "WB %sabled\n", rdev->wb.enabled ? "en" : "dis");
 
        return 0;


[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-3.8.0-rc1+ root=/dev/sda1 ro vga=0 log_bug_len=10M resume=/dev/sda2 no_console_suspend ignore_loglevel hpet=force radeon.no_wb no_wb
[    0.000000] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.8.0-rc1+ root=/dev/sda1 ro vga=0 log_bug_len=10M resume=/dev/sda2 no_console_suspend ignore_loglevel hpet=force radeon.no_wb no_wb

[    6.562905] [drm] radeon kernel modesetting enabled.
[    6.565106] radeon 0000:02:00.0: VRAM: 512M 0x0000000000000000 - 0x000000001FFFFFFF (512M used)
[    6.565172] radeon 0000:02:00.0: GTT: 512M 0x0000000020000000 - 0x000000003FFFFFFF
[    6.567696] [drm] radeon: 512M of VRAM memory ready
[    6.567742] [drm] radeon: 512M of GTT memory ready.
[    6.568068] radeon 0000:02:00.0: irq 42 for MSI/MSI-X
[    6.568130] radeon 0000:02:00.0: radeon: using MSI.
[    6.568269] [drm] radeon: irq initialized.
[    6.684920] radeon_wb_init: disable the goddam WB: radeon_no_wb: 0
[    6.684967] radeon 0000:02:00.0: WB disabled
				    ^^^^^^^^^^^

[    6.685011] radeon 0000:02:00.0: fence driver on ring 0 use gpu addr 0x0000000020000c00 and cpu addr 0xffff880221ea3c00
[    6.685077] radeon 0000:02:00.0: fence driver on ring 3 use gpu addr 0x0000000020000c0c and cpu addr 0xffff880221ea3c0c
[    6.722367] [drm] Radeon Display Connectors
[    6.723548] [drm] radeon: power management initialized
[    6.843185] fbcon: radeondrmfb (fb0) is primary device
[    7.066368] radeon 0000:02:00.0: fb0: radeondrmfb frame buffer device
[    7.066402] radeon 0000:02:00.0: registered panic notifier
[    7.066462] [drm] Initialized radeon 2.27.0 20080528 for 0000:02:00.0 on minor 0

Ok, I hope I turned off the proper WB thing (I'm assuming you meant the
radeon_no_wb parameter).

And I'm running with it now, will report what happens.

Btw, I'm no GPU guy but why does radeon_wb_init() do all that memory
allocation and cleaning if wb can be disabled with a parameter?
Shouldn't it be checking the parameter, ->family, etc setting first and
only do the allocations when rdev->wb.enabled remains true?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2012-12-23 10:55 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-22 20:35 radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec Borislav Petkov
2012-12-23  0:01 ` Alex Deucher
2012-12-23  0:25   ` Borislav Petkov
2012-12-23  0:42     ` Alex Deucher
2012-12-23 10:55       ` Borislav Petkov [this message]
2012-12-23 11:01         ` Andy Furniss
2012-12-23 11:07           ` Borislav Petkov
2012-12-23 11:19             ` Andy Furniss
2012-12-23 11:31               ` Borislav Petkov
2012-12-23 11:51                 ` Markus Trippelsdorf
2012-12-23 12:22                   ` Borislav Petkov
2012-12-23 13:31                     ` Borislav Petkov
2012-12-25  4:50                       ` Shuah Khan
2012-12-25 10:54                         ` Borislav Petkov
2013-01-02  1:42                         ` Antti Palosaari
2013-01-02 12:02                           ` Borislav Petkov
2013-01-02 17:19                             ` Jerome Glisse
2013-01-02 17:58                               ` Antti Palosaari
2013-01-02 22:31                                 ` Jerome Glisse
2013-01-02 22:38                                   ` Markus Trippelsdorf
2013-01-02 23:37                                     ` Alex Deucher
2013-01-02 23:58                                       ` Shuah Khan
2013-01-02 23:59                                         ` Alex Deucher
2013-01-03  1:03                                           ` Antti Palosaari
2013-01-03  1:05                                           ` Shuah Khan
2013-01-03  8:33                                       ` Markus Trippelsdorf
2013-01-03 11:37                                       ` Boszormenyi Zoltan
2013-01-03 14:12                                         ` Deucher, Alexander
2013-01-03 15:30                                           ` Shuah Khan
2013-01-04  7:40                                       ` Borislav Petkov
2013-01-04 11:16                                         ` Boszormenyi Zoltan
2013-01-04 14:06                                           ` Alex Deucher
2012-12-23 11:52           ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2013-01-10  9:38 Borislav Petkov
2013-01-10 16:21 ` Alex Deucher
2013-01-10 20:32   ` Borislav Petkov
2013-01-10 20:47     ` Alex Deucher
2013-01-11 11:43       ` Borislav Petkov
2013-01-15 12:19         ` Borislav Petkov
2013-01-15 14:04           ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121223105527.GA6230@liondog.tnic \
    --to=bp@alien8.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox