* [PATCH] x86: Don't use the EFI reboot method by default
@ 2011-07-06 20:52 Matthew Garrett
2011-07-07 15:08 ` [tip:x86/urgent] " tip-bot for Matthew Garrett
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] Re: [PATCH] " Jonathan Nieder
0 siblings, 2 replies; 6+ messages in thread
From: Matthew Garrett @ 2011-07-06 20:52 UTC (permalink / raw)
To: x86; +Cc: hpa, linux-kernel, Matthew Garrett
Testing suggests that at least some Lenovos and some Intels will fail
to reboot via EFI, attempting to jump to an unmapped physical address.
In the long run we could handle this by providing a page table with a
1:1 mapping of physical addresses, but for now it's probably just easier
to assume that ACPI or legacy methods will be present and reboot via those.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
arch/x86/platform/efi/efi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 06f6666..4f26568 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -540,9 +540,6 @@ void __init efi_init(void)
x86_platform.set_wallclock = efi_set_rtc_mmss;
#endif
- /* Setup for EFI runtime service */
- reboot_type = BOOT_EFI;
-
#if EFI_DEBUG
print_efi_memmap();
#endif
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [tip:x86/urgent] x86: Don't use the EFI reboot method by default
2011-07-06 20:52 [PATCH] x86: Don't use the EFI reboot method by default Matthew Garrett
@ 2011-07-07 15:08 ` tip-bot for Matthew Garrett
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] Re: [PATCH] " Jonathan Nieder
1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for Matthew Garrett @ 2011-07-07 15:08 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, alan, mjg, hpa, mingo, torvalds, akpm, tglx, mingo
Commit-ID: f70e957cda22d309c769805cbb932407a5232219
Gitweb: http://git.kernel.org/tip/f70e957cda22d309c769805cbb932407a5232219
Author: Matthew Garrett <mjg@redhat.com>
AuthorDate: Wed, 6 Jul 2011 16:52:37 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 7 Jul 2011 11:35:05 +0200
x86: Don't use the EFI reboot method by default
Testing suggests that at least some Lenovos and some Intels will
fail to reboot via EFI, attempting to jump to an unmapped
physical address. In the long run we could handle this by
providing a page table with a 1:1 mapping of physical addresses,
but for now it's probably just easier to assume that ACPI or
legacy methods will be present and reboot via those.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/1309985557-15350-1-git-send-email-mjg@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/platform/efi/efi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 474356b..899e393 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -504,9 +504,6 @@ void __init efi_init(void)
x86_platform.set_wallclock = efi_set_rtc_mmss;
#endif
- /* Setup for EFI runtime service */
- reboot_type = BOOT_EFI;
-
#if EFI_DEBUG
print_efi_memmap();
#endif
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot method by default
2011-07-06 20:52 [PATCH] x86: Don't use the EFI reboot method by default Matthew Garrett
2011-07-07 15:08 ` [tip:x86/urgent] " tip-bot for Matthew Garrett
@ 2012-12-23 20:59 ` Jonathan Nieder
2012-12-23 21:03 ` Willy Tarreau
1 sibling, 1 reply; 6+ messages in thread
From: Jonathan Nieder @ 2012-12-23 20:59 UTC (permalink / raw)
To: stable; +Cc: Matthew Garrett, x86, hpa, linux-kernel, Keith Ward,
Ben Hutchings
Hi Willy et al,
Please consider
f70e957cda22 x86: Don't use the EFI reboot method by default,
2011-07-06
for application to the 2.6.32.y and 2.6.34.y trees. The patch was
applied upstream late in the 3.0 cycle, so newer kernels don't need
it.
In 2011, Keith Ward wrote[1]:
> When attempting to reboot my my UEFI enabled system, the system hangs when
> calling reboot requiring me to manually reset the system via the reset switch.
>
> Screenshot: http://twitgoo.com/29bq1c
Ben Hutchings writes[1]:
> Version: 3.0.0-1
>
> I also had this problem on my own system, but it is fixed now.
> I bisected the fix to:
>
> commit f70e957cda22d309c769805cbb932407a5232219
> Author: Matthew Garrett <mjg@redhat.com>
> Date: Wed Jul 6 16:52:37 2011 -0400
>
> x86: Don't use the EFI reboot method by default
>
> which is basically equivalent to the workaround!
>
> I'll also apply this fix to squeeze as it's so simple.
Keith Ward also wrote[1]:
> It seems as if this has recently been reported at Ubuntu's Launchpad as well:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/721576
There are a variety of reports of the same panic at that bug on
2.6.32.y-, 2.6.38.y-, and 2.6.39-based kernels. Passing "reboot=a,w"
on the kernel command line avoids trouble for reporters.
Regards,
Jonathan
[1] http://bugs.debian.org/626022
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot method by default
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] Re: [PATCH] " Jonathan Nieder
@ 2012-12-23 21:03 ` Willy Tarreau
2012-12-23 21:11 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: Willy Tarreau @ 2012-12-23 21:03 UTC (permalink / raw)
To: Jonathan Nieder
Cc: stable, Matthew Garrett, x86, hpa, linux-kernel, Keith Ward,
Ben Hutchings, Paul Gortmaker
Hi Jonathan,
[ccing Paul for 2.6.34]
On Sun, Dec 23, 2012 at 12:59:50PM -0800, Jonathan Nieder wrote:
> Hi Willy et al,
>
> Please consider
>
> f70e957cda22 x86: Don't use the EFI reboot method by default,
> 2011-07-06
>
> for application to the 2.6.32.y and 2.6.34.y trees. The patch was
> applied upstream late in the 3.0 cycle, so newer kernels don't need
> it.
>
> In 2011, Keith Ward wrote[1]:
>
> > When attempting to reboot my my UEFI enabled system, the system hangs when
> > calling reboot requiring me to manually reset the system via the reset switch.
> >
> > Screenshot: http://twitgoo.com/29bq1c
>
> Ben Hutchings writes[1]:
>
> > Version: 3.0.0-1
> >
> > I also had this problem on my own system, but it is fixed now.
> > I bisected the fix to:
> >
> > commit f70e957cda22d309c769805cbb932407a5232219
> > Author: Matthew Garrett <mjg@redhat.com>
> > Date: Wed Jul 6 16:52:37 2011 -0400
> >
> > x86: Don't use the EFI reboot method by default
> >
> > which is basically equivalent to the workaround!
> >
> > I'll also apply this fix to squeeze as it's so simple.
>
> Keith Ward also wrote[1]:
>
> > It seems as if this has recently been reported at Ubuntu's Launchpad as well:
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/721576
>
> There are a variety of reports of the same panic at that bug on
> 2.6.32.y-, 2.6.38.y-, and 2.6.39-based kernels. Passing "reboot=a,w"
> on the kernel command line avoids trouble for reporters.
>
> Regards,
> Jonathan
>
> [1] http://bugs.debian.org/626022
Thanks for the detailed report. I'm queuing it now.
Best regards,
Willy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot method by default
2012-12-23 21:03 ` Willy Tarreau
@ 2012-12-23 21:11 ` Ben Hutchings
2012-12-23 23:33 ` Willy Tarreau
0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2012-12-23 21:11 UTC (permalink / raw)
To: Willy Tarreau
Cc: Jonathan Nieder, stable, Matthew Garrett, x86, hpa, linux-kernel,
Keith Ward, Paul Gortmaker
[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]
On Sun, 2012-12-23 at 22:03 +0100, Willy Tarreau wrote:
> Hi Jonathan,
>
> [ccing Paul for 2.6.34]
>
> On Sun, Dec 23, 2012 at 12:59:50PM -0800, Jonathan Nieder wrote:
> > Hi Willy et al,
> >
> > Please consider
> >
> > f70e957cda22 x86: Don't use the EFI reboot method by default,
> > 2011-07-06
> >
> > for application to the 2.6.32.y and 2.6.34.y trees. The patch was
> > applied upstream late in the 3.0 cycle, so newer kernels don't need
> > it.
> >
> > In 2011, Keith Ward wrote[1]:
> >
> > > When attempting to reboot my my UEFI enabled system, the system hangs when
> > > calling reboot requiring me to manually reset the system via the reset switch.
> > >
> > > Screenshot: http://twitgoo.com/29bq1c
> >
> > Ben Hutchings writes[1]:
> >
> > > Version: 3.0.0-1
> > >
> > > I also had this problem on my own system, but it is fixed now.
> > > I bisected the fix to:
> > >
> > > commit f70e957cda22d309c769805cbb932407a5232219
> > > Author: Matthew Garrett <mjg@redhat.com>
> > > Date: Wed Jul 6 16:52:37 2011 -0400
> > >
> > > x86: Don't use the EFI reboot method by default
> > >
> > > which is basically equivalent to the workaround!
> > >
> > > I'll also apply this fix to squeeze as it's so simple.
> >
> > Keith Ward also wrote[1]:
> >
> > > It seems as if this has recently been reported at Ubuntu's Launchpad as well:
> > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/721576
> >
> > There are a variety of reports of the same panic at that bug on
> > 2.6.32.y-, 2.6.38.y-, and 2.6.39-based kernels. Passing "reboot=a,w"
> > on the kernel command line avoids trouble for reporters.
> >
> > Regards,
> > Jonathan
> >
> > [1] http://bugs.debian.org/626022
>
> Thanks for the detailed report. I'm queuing it now.
In 2.6.32 the relevant code is in arch/x86/kernel/efi.c. With the
filename changed, the patch applies cleanly and works for me.
Ben.
--
Ben Hutchings
One of the nice things about standards is that there are so many of them.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot method by default
2012-12-23 21:11 ` Ben Hutchings
@ 2012-12-23 23:33 ` Willy Tarreau
0 siblings, 0 replies; 6+ messages in thread
From: Willy Tarreau @ 2012-12-23 23:33 UTC (permalink / raw)
To: Ben Hutchings
Cc: Jonathan Nieder, stable, Matthew Garrett, x86, hpa, linux-kernel,
Keith Ward, Paul Gortmaker
On Sun, Dec 23, 2012 at 09:11:36PM +0000, Ben Hutchings wrote:
(...)
> In 2.6.32 the relevant code is in arch/x86/kernel/efi.c. With the
> filename changed, the patch applies cleanly and works for me.
OK, thanks Ben, I had not looked at it yet.
Best regards,
Willy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-23 23:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-06 20:52 [PATCH] x86: Don't use the EFI reboot method by default Matthew Garrett
2011-07-07 15:08 ` [tip:x86/urgent] " tip-bot for Matthew Garrett
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] Re: [PATCH] " Jonathan Nieder
2012-12-23 21:03 ` Willy Tarreau
2012-12-23 21:11 ` Ben Hutchings
2012-12-23 23:33 ` Willy Tarreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox