public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "he, bo" <bo.he@intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	akpm@linux-foundation.org, mingo@elte.hu,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	yanmin_zhang@linux.intel.com
Subject: Re: [PATCH V2] output the cpu number  when printking.
Date: Mon, 24 Dec 2012 09:55:32 -0800	[thread overview]
Message-ID: <20121224175532.GA15041@kroah.com> (raw)
In-Reply-To: <1356325315.2385.74.camel@hebo>

On Mon, Dec 24, 2012 at 01:01:55PM +0800, he, bo wrote:
> From: "he, bo" <bo.he@intel.com>
> 
> We often hit kernel panic issues on SMP machines because processes race
> on multiple cpu. By adding a new parameter printk.cpu, kernel prints
> cpu number at printk information line. It’s useful to debug what cpus
> are racing.

How useful is this really for normal developers?  We complained when
this option was proposed by the ARM developers who were, for the first
time, handling more than one processor and the issues involved with
that.  You are enabling this as a default option, for all developers,
and almost no one will ever need it.

So, if you really want this, don't enable this by default.  Also, go
back and read the old thread about this option and why it was rejeted
previously.

thanks,

greg k-h

  reply	other threads:[~2012-12-24 17:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-24  2:31 [PATCH] output the cpu number when printking he, bo
2012-12-24  3:37 ` Randy Dunlap
2012-12-24  3:54   ` he, bo
2012-12-24  5:01     ` [PATCH V2] " he, bo
2012-12-24 17:55       ` Greg KH [this message]
2012-12-25  1:09         ` Yanmin Zhang
2012-12-26 17:50           ` Greg KH
2012-12-27  6:49             ` He, Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121224175532.GA15041@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bo.he@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdunlap@infradead.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox