From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753464Ab2LXXsk (ORCPT <rfc822;w@1wt.eu>);
	Mon, 24 Dec 2012 18:48:40 -0500
Received: from mail-da0-f48.google.com ([209.85.210.48]:63337 "EHLO
	mail-da0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753377Ab2LXXsi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 24 Dec 2012 18:48:38 -0500
Date: Tue, 25 Dec 2012 07:47:14 +0800
From: Woody Wu <narkewoody@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: kernelnewbies@kernelnewbies.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Subject: Re: Porting problem: ndo_set_multicast_list removed
Message-ID: <20121224234713.GA6756@zuhnb712>
References: <20121224163005.GA3970@zuhnb712>
 <1356376587.20133.9693.camel@edumazet-glaptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1356376587.20133.9693.camel@edumazet-glaptop>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 24, 2012 at 11:16:27AM -0800, Eric Dumazet wrote:
> On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> > Hi, list
> > 
> > I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> > kernel, the ndo_set_multicast_list method in the net_device_ops had been
> > removed. What's the story behind?  Can I simply ignore this method
> > defined in an old driver?
> > 
> > Please also help to check the below code, is the list of the operations
> > defined for my driver enough or not?
> > 
> > const struct net_device_ops ax_netdev_ops = {
> > 	.ndo_open		= mydriver_open,
> > 	.ndo_stop		= mydriver_close,
> > 	.ndo_start_xmit		= mydriver_start_xmit,
> > 	.ndo_get_stats		= mydriver_get_stats,
> > 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> > 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> > };
> > 
> > Thanks in advance.
> > 
> 
> Take a look at :
> 
> commit afc4b13df143122f99a0eb10bfefb216c2806de0
> Author: Jiri Pirko <jpirko@redhat.com>
> Date:   Tue Aug 16 06:29:01 2011 +0000
> 
>     net: remove use of ndo_set_multicast_list in drivers
>     
>     replace it by ndo_set_rx_mode
>     
>     Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> 

Thanks for the info!

-- 
woody
I can't go back to yesterday - because I was a different person then.