From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Sergei Trofimovich <slyfox@gentoo.org>,
xfs@oss.sgi.com, Alex Elder <elder@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org, Ben Myers <bpm@sgi.com>,
Phil White <pwhite@sgi.com>
Subject: Re: [PATCH] xfs: return -EINVAL instead of -EUCLEAN when mounting non-xfs
Date: Sat, 29 Dec 2012 21:29:02 -0500 [thread overview]
Message-ID: <20121230022902.GG20918@thunk.org> (raw)
In-Reply-To: <50DF7D7C.50104@sandeen.net>
On Sat, Dec 29, 2012 at 05:32:12PM -0600, Eric Sandeen wrote:
> yeah, that should work; great minds think alike ;) Our patches
> crossed in the ether I guess.
>
> XFS uses EWRONGFS as an alias for EINVAL internally in these cases,
> so maybe we should stick with that for consistency, *shrug*
I keep thinking we should try expanding the number of errno's so that
the file system can give more fs-specific error codes, such that
eventually, user programs could print out error messages that would
make a lot more sense to users. What we'd have to do is to define the
new errno's, and then wait for the new error_message() strings to
propagate out to a new glibc release, and only then have the kernel
start using the new errno values. It would be a pain in the tuckus to
do, but in the long run the end result would be a lot better for end
users and system administrators.
- Ted
next prev parent reply other threads:[~2012-12-30 2:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121230015615.6cc9e03c@sf>
2012-12-29 23:16 ` [PATCH] xfs: return -EINVAL instead of -EUCLEAN when mounting non-xfs Sergei Trofimovich
2012-12-29 23:32 ` Eric Sandeen
2012-12-30 2:29 ` Theodore Ts'o [this message]
2013-01-03 18:19 ` Christoph Hellwig
2013-01-08 19:48 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230022902.GG20918@thunk.org \
--to=tytso@mit.edu \
--cc=bpm@sgi.com \
--cc=dchinner@redhat.com \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pwhite@sgi.com \
--cc=sandeen@sandeen.net \
--cc=slyfox@gentoo.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox