From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongjin Kim <tobetter@gmail.com>
Cc: "Grant Likely" <grant.likely@secretlab.ca>,
"Rob Herring" <rob.herring@calxeda.com>,
"René Bürgel" <rene.buergel@sohard.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] USB: misc: Add USB3503 High-Speed Hub Controller
Date: Sun, 30 Dec 2012 19:22:00 -0800 [thread overview]
Message-ID: <20121231032200.GA5769@kroah.com> (raw)
In-Reply-To: <1356922268-13098-1-git-send-email-tobetter@gmail.com>
On Mon, Dec 31, 2012 at 11:50:54AM +0900, Dongjin Kim wrote:
> This patch adds new driver of SMSC USB3503 USB 2.0 hub controller with HSIC
> upstream connectivity and three USB 2.0 downstream ports. The specification
> can be found from 'http://www.smsc.com/index.php?tid=295&pid=325'.
>
> The current version have been tested very basic features switching the modes,
> HUB-MODE and STANDBY-MODE.
What causes the modes to be switched? From reading the driver, that
only seems possible to do at boot/load time when the driver reads the
platform data, right? After that, nothing happens to the device from
what I can tell.
Is something going to cause the state of the device to change in the
future?
> + hub->mode = mode;
> + dev_info(&i2c->dev, "switched to HUB mode\n");
Can you please switch all of the dev_info() calls to dev_dbg()? There's
no need to tell the world what is going on in this driver, no one really
cares. And if they do, they can dynamically enable debugging and get
the information then :)
thanks,
greg k-h
next prev parent reply other threads:[~2012-12-31 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 2:50 [PATCH] USB: misc: Add USB3503 High-Speed Hub Controller Dongjin Kim
2012-12-31 3:22 ` Greg Kroah-Hartman [this message]
2012-12-31 3:36 ` Dongjin Kim
-- strict thread matches above, loose matches on Subject: below --
2012-12-07 20:18 tobetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121231032200.GA5769@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rene.buergel@sohard.de \
--cc=rob.herring@calxeda.com \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox