From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Eric Paris <eparis@redhat.com>
Cc: Andrew Vagin <avagin@parallels.com>,
Andrey Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH] prctl: fix validation of an address
Date: Mon, 31 Dec 2012 19:38:33 +0400 [thread overview]
Message-ID: <20121231153833.GA11523@moon> (raw)
In-Reply-To: <1356967247.31923.14.camel@localhost>
On Mon, Dec 31, 2012 at 10:20:47AM -0500, Eric Paris wrote:
>
> Is there anything which prevents an unpriv application from changing
> mm.mm_start_code and mm.mm_end_code in the image, thus taking advantage
> of the privileged restore code to bypass the mmap_min_addr
> restrictions?
Well, you can assign some values in image directly (note the crtools
is running with root priveleges and image files have appropriate
owner:group) because image format is opened and well known from
crtools source code or from protobufer files we use to descibe the
entries in image. Thus it's assumed that administrator/root guarantee
that images are not modified after checkpoint (image signing,
checksumming and such). Also note the members being assigned in
this prctl call are not critical but rather used for statistics
output in procfs as far as I remember.
Cyrill
next prev parent reply other threads:[~2012-12-31 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 11:00 [PATCH] prctl: fix validation of an address Andrey Vagin
2012-12-30 22:03 ` Eric Paris
2012-12-31 10:14 ` Andrew Vagin
2012-12-31 14:27 ` Eric Paris
2012-12-31 15:13 ` Cyrill Gorcunov
2012-12-31 15:20 ` Eric Paris
2012-12-31 15:38 ` Cyrill Gorcunov [this message]
2012-12-31 21:12 ` Serge E. Hallyn
2013-01-01 8:26 ` Andrey Wagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121231153833.GA11523@moon \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=avagin@parallels.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).