From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbdCIMVj (ORCPT ); Thu, 9 Mar 2017 07:21:39 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:56192 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbdCIMVe (ORCPT ); Thu, 9 Mar 2017 07:21:34 -0500 X-AuditID: b6c32a2d-f793d6d0000012b6-3c-58c148c63817 From: Bartlomiej Zolnierkiewicz To: Sergei Shtylyov Cc: Sekhar Nori , Kevin Hilman , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Russell King , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Thu, 09 Mar 2017 13:21:22 +0100 Message-id: <20128022.ebp5ZnzlHx@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHee7dvbsbXnlaWgctrUFhI196ES5lUWlyM6g+1fBDOfKm0aa2 q5IRqJnOpoIaZZpBRVIama7RtJo6R64XJV96EcXI1A+KoGGZZmZc7wK//Tjnf/7P+R8ehtTY qADmbEq6YE4xGLW0WvHMvUUX2sG79BFXe9dxi+UdSq58dIrk5i12grONfKK4jqZvBNf3vJrm BvtYrrWkgeDefp6huc66AeU+NX8lr5jmF36XI36qP1/Jf72+RPDNVUNK/un9bP7D68sU7+l3 EPyMLeiYKl4dlSgYz2YK5vC9Cerkh82dRNoQvjA+NkLmoFesFakYwDuhO79HKfMa6P7yhLYi NaPBNQi6e6cpqaHBFgJyP6f+HyjMq6VkUTWCmZc3vBM/EQy3VCNJReNdUGapW2Y/zMFQ7j2F xCR2E9Du3GBFDLMaH4KG31ulsgJvgomhu0gqs1gHf99dksr+OA7sLRZCYhWOBeds5fKiLF4F c9e+eB2DoaX1OiXzVujqqEfSOoC/KeHNtTlC8gS8HmxtpLx/DLhdrYTMq2HCY/eGD4TFmgEk cwUCxwLIPk8R1L0o9Yp2g9vT433MF0oWRr3+LBQWaGQJD/PjZV75fvg+7SDk8xQSUPthni5F wVUrMlStyFC1IsMdRNahNUKaaEoSxMi07WGiwSRmpCSFnU412dDyT9KFNqEfdw63I8wgrQ8b 0tKm11CGTDHL1I6AIbV+rDHapdewiYasi4I59ZQ5wyiI7SiQUWjXsvERZXoNTjKkC+cEIU0w /+8SjCogBxWEiK6XwoPzqwhrhWvQfbD8VG2lxfeR8VZ+wDZ7V3DRr6PuogoXtdSoYFJMPtGP Z6E+4Vd1/WTxzdkjeP6PtXTkY8bHzTGNefTw9gP+eyz94Tllgz4FsaqxSbpYpS/0pB+PdGae Gb79Vel5NrDj4sYT2dldoYffn3QGOXrjouK0CjHZsE1HmkXDP8qytwtFAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t9jQd2jHgcjDD79M7f4O+kYu8WkJ++Z LX62b2Gy2PT4GqvFsR2PmCwu75rDZnH7Mq/F/t4NTBanrn9msziz6ha7A5dHS3MPm8fvX5MY Pd7faGX3eDD1P5PHzll32T02L6n3uHKiidXj+I3tTB6fN8kFcEa52WSkJqakFimk5iXnp2Tm pdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWPFzjNMBXcFKl4+ fczcwHiUt4uRk0NCwESio3klK4QtJnHh3nq2LkYuDiGBWYwSvW1XmEESQgJfGSXWvYkBsdkE rCQmtq9iBLFFBCwk7jYuYgFpYBY4zCRxcW4zUxcjB4ewgKfEhl86IDUsAqoSr+4uZAQJ8wpo Sfw7XQMSFhXwktiyr50JxOYUcJPY+20mO8TeLYwSVxYcB5vPKyAo8WPyPRYQm1lAXmLf/qms ELaWxPqdx5kmMAJdiVA2C0nZLCRlCxiZVzFKpBYkFxQnpeca5aWW6xUn5haX5qXrJefnbmIE R+kz6R2Mh3e5H2IU4GBU4uEVED4QIcSaWFZcmXuIUYKDWUmEN8f5YIQQb0piZVVqUX58UWlO avEhRlOgBycyS4km5wMTSF5JvKGJuYm5sYGFuaWliZGSOG/j7GfhQgLpiSWp2ampBalFMH1M HJxSDYwavBPMnC/Zulk3n/W8c2bfyvcnXtxvYF9Tx9gr+LNr99pv6YIWpvo3L8wX+1kgwl6o f/rLTL3boZc4Jn/be09zXTG77tTHf5iev30+tybEJFs2+TmbQV7XjQ9OfZ5h2ub8l75OvWyw WLDPuUKozldsv6bZVV+1OKvCk6KbPXsOuk6LqhG/fVCJpTgj0VCLuag4EQCgwaIL6AIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170309122125epcas5p415b1f2266f68d5b999d2eb4ced94e9f3 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170309122125epcas5p415b1f2266f68d5b999d2eb4ced94e9f3 X-RootMTR: 20170309122125epcas5p415b1f2266f68d5b999d2eb4ced94e9f3 References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday, March 09, 2017 12:25:47 PM Sergei Shtylyov wrote: > Hello! > > On 3/9/2017 11:39 AM, Sekhar Nori wrote: > > >>> It took a while to get to it but here is the draft driver patch > >>> against v4.11-rc1. Please test. > >> > >> I tested this on DM6446 EVM. I was able to mount existing partitions on > >> the hard disk and see that the directory listing looks good[1]. I will do > >> more tests (including comparing performance with old driver) tomorrow. I > > > > I completed the tests I wanted to, including some read/write/data > > integrity tests. Performance is same as before too. > > > > Tested-by: Sekhar Nori > > > > Here are the additional changes I did. These changes do not clash with > > what I have already queued for v4.12. That said, its probably better if > > I carry the platform pieces through my tree. Let me know how you want > > to proceed. > > > > Thanks, > > Sekhar > > > > ---8<--- > > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig > > index b9a7cb98ffda..67db82999c06 100644 > > --- a/arch/arm/configs/davinci_all_defconfig > > +++ b/arch/arm/configs/davinci_all_defconfig > [...] > > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c > > index 023480b75244..60a1f23890cd 100644 > > --- a/arch/arm/mach-davinci/board-dm644x-evm.c > > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c > > @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev) > > return 0; > > } > > > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > > I think it would be more correct to check for both libata and IDE drivers > here... Thanks for noticing. To make both drivers work depending on config options selected I'll: - fix these HAS_ATA macros - use "palm_bk3710" as platform driver name in the new driver - drop IDE platform device & IDE clock name changes Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics