Re: [PATCH] checkpatch: prefer dev_( to dev_printk(KERN_

Andy Whitcroft
2013-01-03T10:08:25Z

On Wed, Jan 02, 2013 at 04:06:34PM -0800, Joe Perches wrote:
> Add YA check to printk style.
>
> dev_<level> uses are functions and generate smaller
> object code than dev_printk(KERN_<LEVEL>.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4d2c7df..f50b32d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2430,6 +2430,16 @@ sub process {
> "Prefer pr_warn(... to pr_warning(...\n" . $herecurr);
> }
>
> + if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
> + my $orig = $1;
> + my $level = lc($orig);
> + $level = "warn" if ($level eq "warning");
> + my $level2 = $level;
> + $level2 = "dbg" if ($level eq "debug");

Is there some sublty I am not seeing here such that level2 is necessary?
As far as I can see the two above could be the below to the same effect?

$level2= "dbg" if ($level eq "debug");

(With the obvious change to the print of course)

-apw