From: Christoph Hellwig <hch@infradead.org>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: xfs@oss.sgi.com, Alex Elder <elder@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org, Ben Myers <bpm@sgi.com>,
Phil White <pwhite@sgi.com>
Subject: Re: [PATCH] xfs: return -EINVAL instead of -EUCLEAN when mounting non-xfs
Date: Thu, 3 Jan 2013 13:19:29 -0500 [thread overview]
Message-ID: <20130103181929.GA23049@infradead.org> (raw)
In-Reply-To: <1356823010-29768-1-git-send-email-slyfox@gentoo.org>
On Sun, Dec 30, 2012 at 02:16:50AM +0300, Sergei Trofimovich wrote:
> It fixes boot panic when trying to boot from btrfs filesystem.
> kernel tries to mount as xfs and gets fatal -EUCLEAN:
>
> [ 0.170000] VFS: Cannot open root device "ubda" or unknown-block(98,0): error -117
> [ 0.170000] Please append a correct "root=" boot option; here are the available partitions:
> [ 0.170000] 6200 1048576 ubda driver: uml-blkdev
> [ 0.170000] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(98,0)
>
> init/do_mounts.c expects only -EINVAL as 'retry another' option.
> Fixes regression introduced by commit 98021821a502db347bd9c7671beeee6e8ce07ea6
Looks reasonable, but think xfs_readsb should simply be changed to
turn all EFSCORRUPTED returns into EINVAL if loud is not set. The
place that changes the errno value would also be a perfect place to
comment why we are doing this in the code so that this knowledge doesn't
get lost.
next prev parent reply other threads:[~2013-01-03 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121230015615.6cc9e03c@sf>
2012-12-29 23:16 ` [PATCH] xfs: return -EINVAL instead of -EUCLEAN when mounting non-xfs Sergei Trofimovich
2012-12-29 23:32 ` Eric Sandeen
2012-12-30 2:29 ` Theodore Ts'o
2013-01-03 18:19 ` Christoph Hellwig [this message]
2013-01-08 19:48 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103181929.GA23049@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=dchinner@redhat.com \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pwhite@sgi.com \
--cc=slyfox@gentoo.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox