* [PATCH] namei.h: include errno.h
@ 2012-12-24 18:14 Stephen Warren
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2012-12-24 18:14 UTC (permalink / raw)
To: Jan Kara, Andrew Morton, Andreas Dilger, Jens Axboe
Cc: linux-kernel, linux-ext4, Stephen Warren
This solves:
In file included from fs/ext3/symlink.c:20:0:
include/linux/namei.h: In function 'retry_estale':
include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this function)
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
include/linux/namei.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/namei.h b/include/linux/namei.h
index e998c03..5a5ff57 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -2,6 +2,7 @@
#define _LINUX_NAMEI_H
#include <linux/dcache.h>
+#include <linux/errno.h>
#include <linux/linkage.h>
#include <linux/path.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] namei.h: Include errno.h
@ 2013-01-06 15:48 Guenter Roeck
2013-01-06 15:51 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2013-01-06 15:48 UTC (permalink / raw)
To: Al Viro; +Cc: Jeff Layton, linux-kernel, Guenter Roeck
Commit b9d6ba94 (vfs: add a retry_estale helper function to handle retries
on ESTALE) intruduced the use of ESTALE in namei.h. Since namei.h does not
include errno.h, this results in the following build error for callers/users
which do not include errno.h directly.
include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this
function)
Add the missing include.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
include/linux/namei.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/namei.h b/include/linux/namei.h
index e998c03..92313e4 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -4,6 +4,7 @@
#include <linux/dcache.h>
#include <linux/linkage.h>
#include <linux/path.h>
+#include <linux/errno.h>
struct vfsmount;
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] namei.h: Include errno.h
2013-01-06 15:48 [PATCH] namei.h: Include errno.h Guenter Roeck
@ 2013-01-06 15:51 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2013-01-06 15:51 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Jeff Layton, linux-kernel
On Sun, Jan 06, 2013 at 07:48:49AM -0800, Guenter Roeck wrote:
> Commit b9d6ba94 (vfs: add a retry_estale helper function to handle retries
> on ESTALE) intruduced the use of ESTALE in namei.h. Since namei.h does not
> include errno.h, this results in the following build error for callers/users
> which do not include errno.h directly.
>
> include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this
> function)
>
> Add the missing include.
That's the third patch doing the same thing; see vfs.git#for-linus for the
earliest one. Still not pulled...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-06 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-06 15:48 [PATCH] namei.h: Include errno.h Guenter Roeck
2013-01-06 15:51 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2012-12-24 18:14 [PATCH] namei.h: include errno.h Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox