Re: add Packet hub driver for Topcliff Platform controller hub

Arnd Bergmann
2013-01-08T10:49:22Z

On Monday 07 January 2013, Dan Carpenter wrote:
> Sorry my question is about an old patch. Smatch complains because we
> only pass a PAGE_SIZE buffer to sysfs files so the test for
> "if (count > PCH_PHUB_OROM_SIZE) {" makes it think we are overflowing.
> In fact, count is never more than 4096 so there is no overflow, but I
> also think that it means only the first 4096 bytes of the firmware gets
> updated.

I think it works correctly as long as user space keeps writing into the
bin file when getting short write return (4096 bytes).

Arnd