From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-media@vger.kernel.org, mchehab@infradead.org,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] [media] coda: Fix build due to iram.h rename
Date: Mon, 7 Jan 2013 14:21:22 +0100 [thread overview]
Message-ID: <20130107132122.GV14860@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5Cpa2OYd+v=wE4hbw=sjmQk+bP1HrY49PEWmwRyiVD1dg@mail.gmail.com>
Hello Fabio,
On Mon, Jan 07, 2013 at 08:16:02AM -0200, Fabio Estevam wrote:
> Hi Sascha,
>
> On Mon, Jan 7, 2013 at 8:03 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed the
> > location of iram.h, which causes the following build error when building the coda
> > driver:
> >
> > drivers/media/platform/coda.c:27:23: error: mach/iram.h: No such file or directory
> > drivers/media/platform/coda.c: In function 'coda_probe':
> > drivers/media/platform/coda.c:2000: error: implicit declaration of function 'iram_alloc'
> > drivers/media/platform/coda.c:2001: warning: assignment makes pointer from integer without a cast
> > drivers/media/platform/coda.c: In function 'coda_remove':
> > drivers/media/platform/coda.c:2024: error: implicit declaration of function 'iram_free'
> >
> > Since the content of iram.h is not imx specific, move it to
> > include/linux/platform_data/imx-iram.h instead. This is an intermediate solution
> > until the i.MX iram allocator is converted to the generic SRAM allocator.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >
> > Based on an earlier version from Fabio Estevam, but this one moves iram.h
> > to include/linux/platform_data/imx-iram.h instead of include/linux/iram.h
> > which is a less generic name.
> >
> > arch/arm/mach-imx/iram.h | 41 --------------------------------
> > arch/arm/mach-imx/iram_alloc.c | 3 +--
> > drivers/media/platform/coda.c | 2 +-
> > include/linux/platform_data/imx-iram.h | 41 ++++++++++++++++++++++++++++++++
> > 4 files changed, 43 insertions(+), 44 deletions(-)
> > delete mode 100644 arch/arm/mach-imx/iram.h
> > create mode 100644 include/linux/platform_data/imx-iram.h
>
> It would be better to use git mv /git format-patch -M, so that git can
> detect the file rename.
Note that git-mv is not needed here. Using it doesn't change anything
and you can use git-format-patch -M independant of it.
Best regards
Uwe
next prev parent reply other threads:[~2013-01-07 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 10:03 [PATCH] [media] coda: Fix build due to iram.h rename Sascha Hauer
2013-01-07 10:16 ` Fabio Estevam
2013-01-07 13:21 ` Uwe Kleine-König [this message]
2013-01-07 15:46 ` Mauro Carvalho Chehab
2013-01-07 15:48 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2012-11-14 13:04 Fabio Estevam
2012-12-17 9:37 ` Sascha Hauer
2012-12-27 22:15 ` Mauro Carvalho Chehab
2013-01-02 11:29 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107132122.GV14860@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox