From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Gilad.Ben-Yossef.gilad@benyossef.com
Subject: Re: [PATCH rcu] Remove unused code originally used for context tracking
Date: Mon, 7 Jan 2013 09:39:06 -0800 [thread overview]
Message-ID: <20130107173906.GL2525@linux.vnet.ibm.com> (raw)
In-Reply-To: <1354256362.2552.6.camel@ThinkPad-T5421.cn.ibm.com>
On Fri, Nov 30, 2012 at 02:19:22PM +0800, Li Zhong wrote:
> As new context tracking subsystem added, it seems ignore_user_qs and
> in_user defined in struct rcu_dynticks are no longer needed, so remove
> them.
>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Hearing no objections from Frederic, I have queued this patch for 3.9
Thanx, Paul
> ---
> kernel/rcutree.c | 3 ---
> kernel/rcutree.h | 4 ----
> 2 files changed, 7 deletions(-)
>
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index e441b77..b8fae5d 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -2719,9 +2719,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
> WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != DYNTICK_TASK_EXIT_IDLE);
> WARN_ON_ONCE(atomic_read(&rdp->dynticks->dynticks) != 1);
> -#ifdef CONFIG_RCU_USER_QS
> - WARN_ON_ONCE(rdp->dynticks->in_user);
> -#endif
> rdp->cpu = cpu;
> rdp->rsp = rsp;
> rcu_boot_init_nocb_percpu_data(rdp);
> diff --git a/kernel/rcutree.h b/kernel/rcutree.h
> index 4b69291..6f21f2e 100644
> --- a/kernel/rcutree.h
> +++ b/kernel/rcutree.h
> @@ -102,10 +102,6 @@ struct rcu_dynticks {
> /* idle-period nonlazy_posted snapshot. */
> int tick_nohz_enabled_snap; /* Previously seen value from sysfs. */
> #endif /* #ifdef CONFIG_RCU_FAST_NO_HZ */
> -#ifdef CONFIG_RCU_USER_QS
> - bool ignore_user_qs; /* Treat userspace as extended QS or not */
> - bool in_user; /* Is the CPU in userland from RCU POV? */
> -#endif
> };
>
> /* RCU's kthread states for tracing. */
> --
> 1.7.11.4
>
>
next prev parent reply other threads:[~2013-01-07 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1354041205-6989-1-git-send-email-fweisbec@gmail.com>
2012-11-28 0:59 ` [PATCH] context_tracking: New context tracking susbsystem Paul E. McKenney
2012-11-28 1:50 ` Steven Rostedt
2012-11-28 2:04 ` Paul E. McKenney
2012-11-29 9:06 ` Li Zhong
2012-11-29 10:30 ` Frederic Weisbecker
2012-11-29 11:36 ` Paul E. McKenney
2012-11-30 6:19 ` [PATCH rcu] Remove unused code originally used for context tracking Li Zhong
2013-01-07 17:39 ` Paul E. McKenney [this message]
2013-01-07 17:46 ` Frederic Weisbecker
2013-01-07 17:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107173906.GL2525@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Gilad.Ben-Yossef.gilad@benyossef.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox