public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/sb105x: remove asm/segment.h dependency
Date: Mon, 7 Jan 2013 14:36:09 -0800	[thread overview]
Message-ID: <20130107223609.GA27477@kroah.com> (raw)
In-Reply-To: <50EB4A3B.1020307@suse.com>

On Mon, Jan 07, 2013 at 05:20:43PM -0500, Jeff Mahoney wrote:
> sb105x doesn't seem to actually need <asm/segment.h> (builds on x86
> without it) and ppc/ppc64 doesn't provide it so it fails to build there.
> 
> This patch removes the dependency. Unfortunately, it now fails to build
> because STD_COM_FLAGS isn't defined on most architectures. I'm not familiar
> enough with the tty/serial system to patch that aspect of it.
> 
> CC: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
> 
>  drivers/staging/sb105x/sb_pci_mp.h |    1 -
>  1 file changed, 1 deletion(-)

I just committed a patch from Steven that keeps this driver from
building at all on non-x86 platforms, and it should show up in Linus's
next release.  That should solve the build issue for you, so I'll hold
off on applying this one, and let Steven fix it properly.

thanks,

greg k-h

      parent reply	other threads:[~2013-01-07 22:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 22:20 [PATCH] staging/sb105x: remove asm/segment.h dependency Jeff Mahoney
2013-01-07 22:36 ` Steven Rostedt
2013-01-08  2:31   ` Jeff Mahoney
2013-01-07 22:36 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107223609.GA27477@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox