From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Harvey Yang <harvey.huawei.yang@gmail.com>
Cc: Matt Mooney <mfm@muteddisk.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: usbip: use interrupt safe spinlock to avoid potential deadlock.
Date: Mon, 7 Jan 2013 21:51:28 -0800 [thread overview]
Message-ID: <20130108055128.GA4561@kroah.com> (raw)
In-Reply-To: <1357624142-7178-2-git-send-email-harvey.huawei.yang@gmail.com>
On Tue, Jan 08, 2013 at 01:49:01PM +0800, Harvey Yang wrote:
>
> Signed-off-by: Harvey Yang <harvey.huawei.yang@gmail.com>
You need to describe _why_ you did this, not just what you did. Why is
this needed? What are you fixing by doing this? Is this something that
older kernels need? Is it something that others are seeing?
Same goes for patch 2/2 here, you have to provide a good changelog entry
in order for this to be accepted.
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-08 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 5:49 [PATCH 0/2] staging: usbip: refine the lock Harvey Yang
2013-01-08 5:49 ` [PATCH 1/2] staging: usbip: use interrupt safe spinlock to avoid potential deadlock Harvey Yang
2013-01-08 5:51 ` Greg Kroah-Hartman [this message]
2013-01-08 5:49 ` [PATCH 2/2] staging: usbip: replace the interrupt safe spinlocks with common ones Harvey Yang
2013-01-08 5:52 ` [PATCH 0/2] staging: usbip: refine the lock Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108055128.GA4561@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=harvey.huawei.yang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mfm@muteddisk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox