public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Tom St Denis <tstdenis@elliptictech.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
	herbert@gondor.hengli.com.au
Subject: Re: [PATCH]  Added NIST CMAC to the CryptoAPI library
Date: Tue, 8 Jan 2013 09:54:25 +0100	[thread overview]
Message-ID: <20130108085425.GU18940@secunet.com> (raw)
In-Reply-To: <231929285.161561.1355252410408.JavaMail.root@elliptictech.com>

On Tue, Dec 11, 2012 at 02:00:10PM -0500, Tom St Denis wrote:
> This patch adds NIST CMAC cipher based MAC as described in FIPS 800-38B to
> the CryptoAPI stack.  It also wires up the MAC to the IPsec stack as per
> RFC 4494.
> 
> This patch was tested against 3.7 with third party hardware IPsec.
> 
> Signed-off-by: Tom St Denis <tstdenis@elliptictech.com>
> Acked-by: David S. Miller <davem@davemloft.net>
> 

I agreed with Herbert Xu to integrate this via the ipsec-next tree.

However, it introduces the following warning:

crypto/cmac.c: In function ‘crypto_cmac_digest_setkey’:
crypto/cmac.c:97:4: warning: suggest parentheses around arithmetic in
operand of ‘^’ [-Wparentheses]

It also has a lot of coding style issues, run checkpatch.

Please fix it and resend.

Thanks!

  reply	other threads:[~2013-01-08  9:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1068116509.71782.1353434081056.JavaMail.root@elliptictech.com>
2012-12-11 19:00 ` [PATCH] Added NIST CMAC to the CryptoAPI library Tom St Denis
2013-01-08  8:54   ` Steffen Klassert [this message]
2013-01-08 10:59     ` Tom St Denis
2012-11-20 15:24 Tom St Denis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130108085425.GU18940@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tstdenis@elliptictech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox