From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Boris BREZILLON <linux-arm@overkiz.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Andrew Victor <linux@maxim.org.za>,
linux-kernel@vger.kernel.org,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>
Subject: Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver
Date: Tue, 8 Jan 2013 15:25:55 +0000 [thread overview]
Message-ID: <20130108152555.GC3931@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <50EC3997.5050702@overkiz.com>
On Tue, Jan 08, 2013 at 04:21:59PM +0100, Boris BREZILLON wrote:
> Do I have to break the error string so that the line does not exceed 80
> characters ?
No.
> Checkpath script does not complain about it, and the CodingStyle file
> specify that visible strings should not be broken...
Correct.
> Same question applies to this error, which I converted to a multi-line
> error in a previous patch version:
>
> dev_err(chip->dev,
> "failed to configure period_ns:\n"
> "the other PWM device in this group is already\n"
> "configured with a different period_ns value\n");
Which is a bad idea. It appears in log files as multiple lines, which
makes parsing the error for analysis difficult (eg, you may have a
log analyser which tells you how many times an error occurs - the
above would be treated as three separate errors.
prev parent reply other threads:[~2013-01-08 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 9:12 [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver Boris BREZILLON
2013-01-08 7:10 ` Thierry Reding
2013-01-08 12:43 ` Boris BREZILLON
2013-01-08 13:15 ` Thierry Reding
2013-01-08 15:21 ` Boris BREZILLON
2013-01-08 15:25 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108152555.GC3931@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=linux-arm@overkiz.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).