From: Greg KH <greg@kroah.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Sam Hansen <solid.se7en@gmail.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESEND] staging: zram: fix invalid memory references during disk write
Date: Tue, 8 Jan 2013 14:13:14 -0800 [thread overview]
Message-ID: <20130108221314.GA29852@kroah.com> (raw)
In-Reply-To: <CAPkvG_eY8Fucft_Up9HgxWbpr2YG8vCQ_Pwi3QMfxcgDkgQ+Tg@mail.gmail.com>
On Tue, Jan 08, 2013 at 02:00:27PM -0800, Nitin Gupta wrote:
> On Fri, Jan 4, 2013 at 12:25 PM, Nitin Gupta <ngupta@vflare.org> wrote:
> > On Wed, Jan 2, 2013 at 8:53 AM, Nitin Gupta <ngupta@vflare.org> wrote:
> >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling
> >> of incompressible pages") which caused invalid memory references
> >> during disk write. Invalid references could occur in two cases:
> >> - Incoming data expands on compression: In this case, reference was
> >> made to kunmap()'ed bio page.
> >> - Partial (non PAGE_SIZE) write with incompressible data: In this
> >> case, reference was made to a kfree()'ed buffer.
> >>
> >> Fixes bug 50081:
> >> https://bugzilla.kernel.org/show_bug.cgi?id=50081
> >>
> >
> > Greg: can you please add this to staging? It fixes an important issue
> > and is tested by many users.
> >
>
>
> It's still not in staging. Any reason why you want to accept this patch?
Because I'm still catching up after being on vacation for 3 weeks? I
only got back yesterday and have a few thousand emails/patches to make
it through. Patches for staging drivers are way down on the list of
priorities for me, especially the zram/zcache/zwhatever mess that we
currently have...
Don't worry, it's not lost, and will make it in soon, please give me a
chance.
greg k-h
prev parent reply other threads:[~2013-01-08 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 16:53 [PATCH][RESEND] staging: zram: fix invalid memory references during disk write Nitin Gupta
2013-01-04 20:25 ` Nitin Gupta
2013-01-08 22:00 ` Nitin Gupta
2013-01-08 22:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108221314.GA29852@kroah.com \
--to=greg@kroah.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=jmarchan@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan.kim@gmail.com \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=solid.se7en@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox