From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757658Ab3AIMXa (ORCPT ); Wed, 9 Jan 2013 07:23:30 -0500 Received: from mail-bk0-f47.google.com ([209.85.214.47]:38509 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757506Ab3AIMX3 (ORCPT ); Wed, 9 Jan 2013 07:23:29 -0500 Date: Wed, 9 Jan 2013 12:23:23 +0000 From: Lee Jones To: Russell King - ARM Linux Cc: Arnd Bergmann , sameo@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.walleij@stericsson.com Subject: Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger Message-ID: <20130109122323.GE31678@gmail.com> References: <1357725965-27342-1-git-send-email-lee.jones@linaro.org> <1357725965-27342-2-git-send-email-lee.jones@linaro.org> <201301091018.55058.arnd@arndb.de> <20130109103510.GE3931@n2100.arm.linux.org.uk> <20130109110840.GD31678@gmail.com> <20130109111209.GH3931@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130109111209.GH3931@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Jan 2013, Russell King - ARM Linux wrote: > On Wed, Jan 09, 2013 at 11:08:40AM +0000, Lee Jones wrote: > > On Wed, 09 Jan 2013, Russell King - ARM Linux wrote: > > > > > On Wed, Jan 09, 2013 at 10:18:54AM +0000, Arnd Bergmann wrote: > > > > On Wednesday 09 January 2013, Lee Jones wrote: > > > > > diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig > > > > > index 5dea906..0f25b07 100644 > > > > > --- a/arch/arm/mach-ux500/Kconfig > > > > > +++ b/arch/arm/mach-ux500/Kconfig > > > > > @@ -43,6 +43,8 @@ config MACH_HREFV60 > > > > > config MACH_SNOWBALL > > > > > bool "U8500 Snowball platform" > > > > > select MACH_MOP500 > > > > > + select LEDS_TRIGGERS > > > > > + select LEDS_TRIGGER_HEARTBEAT > > > > > help > > > > > Include support for the snowball development platform. > > > > > > > > Be careful with "select" statements like this when there are other > > > > dependencies. I think LEDS_TRIGGERS depends on LEDS_CLASS, so this > > > > should probably be written as > > > > > > > > select LEDS_TRIGGERS if LEDS_CLASS > > > > > > Umm, this is also wrong for another reason. LEDS is an optional feature. > > > It's not required for the platform to be functional. So why the hell would > > > anyone want to _force_ such an optional feature to be mandatory? > > > > > > This is something that the default config published for the platform should > > > be handling. > > > > Do you mean /u8500_defconfig? > > > > If so, that's wrong, as it covers many more boards than just Snowball > > and this is only applicable on the Snowball board. So how else can > > I enable this feature? > > And why is it wrong to enable an optional feature in a defconfig which some > boards using that defconfig may want? > > It's _less_ wrong than forcing user selectable options to be mandatorily > selected. Excuse my ignorance, but I'm a little confused by this. What's the difference between 'select