From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757961Ab3AIOmr (ORCPT ); Wed, 9 Jan 2013 09:42:47 -0500 Received: from mga14.intel.com ([143.182.124.37]:42480 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757828Ab3AIOmq (ORCPT ); Wed, 9 Jan 2013 09:42:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,438,1355126400"; d="scan'208";a="241818060" Date: Wed, 9 Jan 2013 06:18:26 -0800 From: Vinod Koul To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Viresh Kumar , spear-devel Subject: Re: [resend][PATCH 16/16] dma: dw_dmac: clear suspend bit during termination Message-ID: <20130109141826.GP19691@intel.com> References: <20130108155423.GJ19691@intel.com> <1357719435-29955-1-git-send-email-andriy.shevchenko@linux.intel.com> <1357719435-29955-17-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357719435-29955-17-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2013 at 10:17:15AM +0200, Andy Shevchenko wrote: > From: Heikki Krogerus > > The DMA transfer could not be established if previously it was paused and > terminated. In that case the channel's suspend bit remains set that prevents to > transfer anything until channel is resumed. > > The patch adds a code that clears the DWC_CFGL_CH_SUSP bit during termination. No this patch calls resume to do so... Can you update the change log > > Signed-off-by: Heikki Krogerus > Signed-off-by: Andy Shevchenko > Acked-by: Viresh Kumar > --- > drivers/dma/dw_dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > index 6a8f8c7..c6ebea1 100644 > --- a/drivers/dma/dw_dmac.c > +++ b/drivers/dma/dw_dmac.c > @@ -1059,7 +1059,7 @@ static int dwc_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd, > > dwc_chan_disable(dw, dwc); > > - dwc->paused = false; > + dwc_chan_resume(dwc); > > /* active_list entries will end up before queued entries */ > list_splice_init(&dwc->queue, &list); > -- > 1.7.10.4 >