From: Matt Porter <mporter@ti.com>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
Date: Wed, 9 Jan 2013 11:52:35 -0500 [thread overview]
Message-ID: <20130109165235.GJ14660@beef> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EAD58CF@DBDE01.ent.ti.com>
On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote:
> On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> > TPS65910 mfd driver uses functions that are only avaiable when
> > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> > Kconfig to fix below build error:
> >
> > drivers/built-in.o: In function `tps65910_irq_exit':
> > /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> > drivers/built-in.o: In function `tps65910_irq_init':
> > /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> > drivers/built-in.o: In function `tps65910_i2c_probe':
> > /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> > make: *** [vmlinux] Error 1
> >
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> > drivers/mfd/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 1c0abd4..01413a2 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -237,6 +237,7 @@ config MFD_TPS65910
> > depends on I2C=y && GPIOLIB
> > select MFD_CORE
> > select REGMAP_I2C
> > + select REGMAP_IRQ
> > select IRQ_DOMAIN
> > help
> > if you say yes here you get support for the TPS65910 series of
>
> Hi Samuel,
>
> Could you please pull this fix?
Tested-by: Matt Porter <mporter@ti.com>
Fixes broken OMAP kernel build here too.
-Matt
next prev parent reply other threads:[~2013-01-09 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 11:14 [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error AnilKumar Ch
2012-12-17 5:58 ` AnilKumar, Chimata
2013-01-02 10:15 ` AnilKumar, Chimata
2013-01-09 16:52 ` Matt Porter [this message]
2013-01-18 11:12 ` AnilKumar, Chimata
2013-01-22 0:28 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109165235.GJ14660@beef \
--to=mporter@ti.com \
--cc=anilkumar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox