* [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
@ 2012-12-10 11:14 AnilKumar Ch
2012-12-17 5:58 ` AnilKumar, Chimata
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: AnilKumar Ch @ 2012-12-10 11:14 UTC (permalink / raw)
To: sameo; +Cc: linux-kernel, AnilKumar Ch
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
Kconfig to fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
drivers/built-in.o: In function `tps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
drivers/built-in.o: In function `tps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 1c0abd4..01413a2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -237,6 +237,7 @@ config MFD_TPS65910
depends on I2C=y && GPIOLIB
select MFD_CORE
select REGMAP_I2C
+ select REGMAP_IRQ
select IRQ_DOMAIN
help
if you say yes here you get support for the TPS65910 series of
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
2012-12-10 11:14 [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error AnilKumar Ch
@ 2012-12-17 5:58 ` AnilKumar, Chimata
2013-01-02 10:15 ` AnilKumar, Chimata
2013-01-22 0:28 ` Samuel Ortiz
2 siblings, 0 replies; 6+ messages in thread
From: AnilKumar, Chimata @ 2012-12-17 5:58 UTC (permalink / raw)
To: AnilKumar, Chimata, sameo@linux.intel.com; +Cc: linux-kernel@vger.kernel.org
On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> TPS65910 mfd driver uses functions that are only avaiable when
> REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> Kconfig to fix below build error:
>
> drivers/built-in.o: In function `tps65910_irq_exit':
> /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps65910_irq_init':
> /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps65910_i2c_probe':
> /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1c0abd4..01413a2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -237,6 +237,7 @@ config MFD_TPS65910
> depends on I2C=y && GPIOLIB
> select MFD_CORE
> select REGMAP_I2C
> + select REGMAP_IRQ
> select IRQ_DOMAIN
> help
> if you say yes here you get support for the TPS65910 series of
Hi Samuel,
If there are no comments on this patch could you please pull?
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
2012-12-10 11:14 [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error AnilKumar Ch
2012-12-17 5:58 ` AnilKumar, Chimata
@ 2013-01-02 10:15 ` AnilKumar, Chimata
2013-01-09 16:52 ` Matt Porter
2013-01-22 0:28 ` Samuel Ortiz
2 siblings, 1 reply; 6+ messages in thread
From: AnilKumar, Chimata @ 2013-01-02 10:15 UTC (permalink / raw)
To: AnilKumar, Chimata, sameo@linux.intel.com; +Cc: linux-kernel@vger.kernel.org
On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> TPS65910 mfd driver uses functions that are only avaiable when
> REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> Kconfig to fix below build error:
>
> drivers/built-in.o: In function `tps65910_irq_exit':
> /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps65910_irq_init':
> /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps65910_i2c_probe':
> /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1c0abd4..01413a2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -237,6 +237,7 @@ config MFD_TPS65910
> depends on I2C=y && GPIOLIB
> select MFD_CORE
> select REGMAP_I2C
> + select REGMAP_IRQ
> select IRQ_DOMAIN
> help
> if you say yes here you get support for the TPS65910 series of
Hi Samuel,
Could you please pull this fix?
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
2013-01-02 10:15 ` AnilKumar, Chimata
@ 2013-01-09 16:52 ` Matt Porter
2013-01-18 11:12 ` AnilKumar, Chimata
0 siblings, 1 reply; 6+ messages in thread
From: Matt Porter @ 2013-01-09 16:52 UTC (permalink / raw)
To: AnilKumar, Chimata; +Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org
On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote:
> On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> > TPS65910 mfd driver uses functions that are only avaiable when
> > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> > Kconfig to fix below build error:
> >
> > drivers/built-in.o: In function `tps65910_irq_exit':
> > /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> > drivers/built-in.o: In function `tps65910_irq_init':
> > /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> > drivers/built-in.o: In function `tps65910_i2c_probe':
> > /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> > make: *** [vmlinux] Error 1
> >
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> > drivers/mfd/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 1c0abd4..01413a2 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -237,6 +237,7 @@ config MFD_TPS65910
> > depends on I2C=y && GPIOLIB
> > select MFD_CORE
> > select REGMAP_I2C
> > + select REGMAP_IRQ
> > select IRQ_DOMAIN
> > help
> > if you say yes here you get support for the TPS65910 series of
>
> Hi Samuel,
>
> Could you please pull this fix?
Tested-by: Matt Porter <mporter@ti.com>
Fixes broken OMAP kernel build here too.
-Matt
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
2013-01-09 16:52 ` Matt Porter
@ 2013-01-18 11:12 ` AnilKumar, Chimata
0 siblings, 0 replies; 6+ messages in thread
From: AnilKumar, Chimata @ 2013-01-18 11:12 UTC (permalink / raw)
To: sameo@linux.intel.com; +Cc: Porter, Matt, linux-kernel@vger.kernel.org
On Wed, Jan 09, 2013 at 22:22:35, Porter, Matt wrote:
> On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote:
> > On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> > > TPS65910 mfd driver uses functions that are only avaiable when
> > > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> > > Kconfig to fix below build error:
> > >
> > > drivers/built-in.o: In function `tps65910_irq_exit':
> > > /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> > > drivers/built-in.o: In function `tps65910_irq_init':
> > > /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> > > drivers/built-in.o: In function `tps65910_i2c_probe':
> > > /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> > > make: *** [vmlinux] Error 1
> > >
> > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index 1c0abd4..01413a2 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -237,6 +237,7 @@ config MFD_TPS65910
> > > depends on I2C=y && GPIOLIB
> > > select MFD_CORE
> > > select REGMAP_I2C
> > > + select REGMAP_IRQ
> > > select IRQ_DOMAIN
> > > help
> > > if you say yes here you get support for the TPS65910 series of
> >
> > Hi Samuel,
> >
> > Could you please pull this fix?
>
> Tested-by: Matt Porter <mporter@ti.com>
>
> Fixes broken OMAP kernel build here too.
>
Hi Samuel,
Could you please take this in?
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
2012-12-10 11:14 [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error AnilKumar Ch
2012-12-17 5:58 ` AnilKumar, Chimata
2013-01-02 10:15 ` AnilKumar, Chimata
@ 2013-01-22 0:28 ` Samuel Ortiz
2 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2013-01-22 0:28 UTC (permalink / raw)
To: AnilKumar Ch; +Cc: linux-kernel
Hi Anilkumar,
On Mon, Dec 10, 2012 at 04:44:56PM +0530, AnilKumar Ch wrote:
> TPS65910 mfd driver uses functions that are only avaiable when
> REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> Kconfig to fix below build error:
>
> drivers/built-in.o: In function `tps65910_irq_exit':
> /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps65910_irq_init':
> /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps65910_i2c_probe':
> /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied to my for-linus branch. Sorry for not carrying it with my 3.8 pull
request.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-22 0:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-10 11:14 [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error AnilKumar Ch
2012-12-17 5:58 ` AnilKumar, Chimata
2013-01-02 10:15 ` AnilKumar, Chimata
2013-01-09 16:52 ` Matt Porter
2013-01-18 11:12 ` AnilKumar, Chimata
2013-01-22 0:28 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox