From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753707Ab3AJNSe (ORCPT ); Thu, 10 Jan 2013 08:18:34 -0500 Received: from linux-sh.org ([111.68.239.195]:46459 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938Ab3AJNSc (ORCPT ); Thu, 10 Jan 2013 08:18:32 -0500 Date: Thu, 10 Jan 2013 22:18:28 +0900 From: Paul Mundt To: Julia Lawall Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: clk dereference in arch/sh/kernel/cpufreq.c Message-ID: <20130110131828.GC7785@linux-sh.org> References: <20130110085923.GA7785@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 10, 2013 at 10:31:46AM +0100, Julia Lawall wrote: > On Thu, 10 Jan 2013, Paul Mundt wrote: > > > On Thu, Jan 03, 2013 at 10:40:20AM +0100, Julia Lawall wrote: > > > There has been a discussion recently about how the result of get_clk > > > should be an opaque handle, not a value that can be dereferenced: > > > > > > https://lkml.org/lkml/2012/12/20/105 > > > > > > There is such a dereference in arch/sh/kernel/cpufreq.c, in the function > > > sh_cpufreq_cpu_init: > > > > > > freq_table = cpuclk->nr_freqs ? cpuclk->freq_table : NULL; > > > > > > It was not obvious to me, however, what API function should be used > > > instead, so I am just reporting the (potential) problem. > > > > > In this case we would have to add some new API for fetching the frequency > > table associated with the struct clk, which is reasonably > > straightforward. It's not obvious how a private API vs deref of a type we > > have a private definition for is any better or worse, though. This code > > is not aimed at the common struct clk in any event. > > OK, maybe it should just be left as is? > That would be in line with my intentions.