From: Alan Cox <alan@linux.intel.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, gaowanlong@cn.fujitsu.com,
gregkh@linuxfoundation.org, frank@lichtenheld.de
Subject: Re: regression, bisected: openpty fails from 3.7 onwards without devpts
Date: Thu, 10 Jan 2013 22:45:54 +0000 [thread overview]
Message-ID: <20130110224554.1724a791@bob.linux.org.uk> (raw)
In-Reply-To: <50EEF8FD.9000004@suse.cz>
> getptsname expects EINVAL on failure to fall back to /dev/ttyp*... The
> same as unlockpt. We should definitely revert now and can teach glibc
> to accept also ENOTTY. After some years, we can try again :).
Strongly disagree for two reasons
1. We don't want to leave the other ioctls broken and non-compliant if
we can avoid it.
2. The userspace code here has quite reasonable expectations which are
that TIOCGPTN is not an unknown ioctl but is invalid to use in this
situation.
So we should just fix TIOCGPTN on a pty with no suitable name answer to
return -EINVAL (even though it would be fun to break userspace and make
Linus teach more rude words to non English speakers).
In this case I think the userspace expectations are actually perfectly
fair anyway even without considering the rather important criterion
of 'it worked last week')
Alan
next prev parent reply other threads:[~2013-01-10 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 14:46 regression, bisected: openpty fails from 3.7 onwards without devpts Florian Westphal
2013-01-10 15:50 ` Alan Cox
2013-01-10 16:29 ` Florian Westphal
2013-01-10 17:23 ` Jiri Slaby
2013-01-10 20:13 ` Jiri Slaby
2013-01-10 22:45 ` Alan Cox [this message]
2013-01-10 22:51 ` Jiri Slaby
2013-01-11 11:11 ` Jiri Slaby
2013-01-11 12:41 ` Florian Westphal
2013-01-11 12:44 ` Jiri Slaby
2013-01-11 13:18 ` Alan Cox
2013-01-17 16:29 ` Greg KH
2013-01-17 16:34 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110224554.1724a791@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=frank@lichtenheld.de \
--cc=fw@strlen.de \
--cc=gaowanlong@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox