From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [perf PATCH] Use pclose() instead of fclose() on pipe stream
Date: Fri, 11 Jan 2013 01:16:03 -0300 [thread overview]
Message-ID: <20130111041603.GB3054@ghostprotocols.net> (raw)
In-Reply-To: <50D9CDFC.3010101@intra2net.com>
Em Tue, Dec 25, 2012 at 05:02:04PM +0100, Thomas Jarosch escreveu:
> cppcheck message:
> [tools/perf/util/sort.c:277]: (error) Mismatching allocation and deallocation: fp
>
> Also fix descriptor leak on error
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> tools/perf/util/sort.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
After applying this:
CC /home/acme/git/build/perf/util/cpumap.o
cc1: warnings being treated as errors
util/sort.c: In function ‘hist_entry__srcline_snprintf’:
util/sort.c:254: error: ‘fp’ may be used uninitialized in this function
make: *** [/home/acme/git/build/perf/util/sort.o] Error 1
- Arnaldo
next prev parent reply other threads:[~2013-01-11 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 16:02 [perf PATCH] Use pclose() instead of fclose() on pipe stream Thomas Jarosch
2013-01-11 4:16 ` Arnaldo Carvalho de Melo [this message]
2013-01-16 9:09 ` Thomas Jarosch
2013-01-16 18:13 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111041603.GB3054@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).