* [patch] dac960: return success instead of -ENOTTY
@ 2013-01-11 6:52 Dan Carpenter
2013-01-11 10:27 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-01-11 6:52 UTC (permalink / raw)
To: Jens Axboe; +Cc: Danny Kukawka, Jesper Juhl, linux-kernel, kernel-janitors
There is a missing break statement here. This used to return directly
but we re-worked it in 2008 to add locking as part of the BKL push down.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 9a13e88..0d3ffc5 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -7054,6 +7054,7 @@ static long DAC960_gam_ioctl(struct file *file, unsigned int Request,
else
ErrorCode = 0;
}
+ break;
default:
ErrorCode = -ENOTTY;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] dac960: return success instead of -ENOTTY
2013-01-11 6:52 [patch] dac960: return success instead of -ENOTTY Dan Carpenter
@ 2013-01-11 10:27 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2013-01-11 10:27 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Danny Kukawka, Jesper Juhl, linux-kernel, kernel-janitors
On 2013-01-11 07:52, Dan Carpenter wrote:
> There is a missing break statement here. This used to return directly
> but we re-worked it in 2008 to add locking as part of the BKL push down.
Thanks Dan, applied. Must have a big user base...
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-11 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-11 6:52 [patch] dac960: return success instead of -ENOTTY Dan Carpenter
2013-01-11 10:27 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox