From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203Ab3AKOZc (ORCPT ); Fri, 11 Jan 2013 09:25:32 -0500 Received: from mail-qc0-f174.google.com ([209.85.216.174]:43183 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022Ab3AKOZa (ORCPT ); Fri, 11 Jan 2013 09:25:30 -0500 Date: Fri, 11 Jan 2013 09:30:07 -0500 From: Matt Porter To: "Hebbar, Gururaja" Cc: Linux DaVinci Kernel List , Arnd Bergmann , Linux Documentation List , Devicetree Discuss , Linux MMC List , Linux Kernel Mailing List , Rob Herring , Dan Williams , Linux SPI Devel List , Linux OMAP List , Linux ARM Kernel List , Tony Lindgren , "Nori, Sekhar" , Grant Likely , Mark Brown , "Cousson, Benoit" , Russell King , Vinod Koul , Rob Landley , Chris Ball Subject: Re: [PATCH v4 05/14] dmaengine: edma: Add TI EDMA device tree binding Message-ID: <20130111143007.GX14660@beef> References: <1357883330-5364-1-git-send-email-mporter@ti.com> <1357883330-5364-6-git-send-email-mporter@ti.com> <06e6ba0bd8984e1797c84d2926584909@DFLE72.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06e6ba0bd8984e1797c84d2926584909@DFLE72.ent.ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 11, 2013 at 07:54:05AM +0000, Hebbar, Gururaja wrote: > On Fri, Jan 11, 2013 at 11:18:41, Porter, Matt wrote: > > The binding definition is based on the generic DMA controller > > binding. > > > > Signed-off-by: Matt Porter > > --- > > Documentation/devicetree/bindings/dma/ti-edma.txt | 51 +++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt > > > > diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt > > new file mode 100644 > > index 0000000..3344345 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt > > @@ -0,0 +1,51 @@ > > +TI EDMA > > + > > +Required properties: > > +- compatible : "ti,edma3" > > +- ti,hwmods: Name of the hwmods associated to the EDMA > > +- ti,edma-regions: Number of regions > > +- ti,edma-slots: Number of slots > > +- ti,edma-queue-tc-map: List of transfer control to queue mappings > > +- ti,edma-queue-priority-map: List of queue priority mappings > > +- ti,edma-default-queue: Default queue value > > + > > +Optional properties: > > +- ti,edma-reserved-channels: List of reserved channel regions > > +- ti,edma-reserved-slots: List of reserved slot regions > > +- ti,edma-xbar-event-map: Crossbar event to channel map > > + > > +Example: > > + > > +edma: edma@49000000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > address-cells & size-cells are only required when current node is a parent > node & it has sibling/child nodes (that too if the child node uses "reg" > property). Yes, agreed. I addressed this in the actual dts but failed to update the binding itself. Will update. > > > + reg = <0x49000000 0x10000>; > > + interrupt-parent = <&intc>; > > + interrupts = <12 13 14>; > > + compatible = "ti,edma3"; > > + ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2"; > > + #dma-cells = <1>; > > + dma-channels = <64>; > > + ti,edma-regions = <4>; > > + ti,edma-slots = <256>; > > + ti,edma-reserved-channels = <0 2 > > + 14 2 > > + 26 6 > > + 48 4 > > + 56 8>; > > + ti,edma-reserved-slots = <0 2 > > + 14 2 > > + 26 6 > > + 48 4 > > + 56 8 > > + 64 127>; > > + ti,edma-queue-tc-map = <0 0 > > + 1 1 > > + 2 2>; > > + ti,edma-queue-priority-map = <0 0 > > + 1 1 > > + 2 2>; > > + ti,edma-default-queue = <0>; > > + ti,edma-xbar-event-map = <1 12 > > + 2 13>; > > +}; > > -- > > 1.7.9.5 > > > > _______________________________________________ > > Davinci-linux-open-source mailing list > > Davinci-linux-open-source@linux.davincidsp.com > > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source > > > > > Regards, > Gururaja