Re: [resend][PATCH 01/16] dw_dmac: call .probe after we have a device in place

Vinod Koul
2013-01-09T14:12:19Z

On Wed, Jan 09, 2013 at 10:17:00AM +0200, Andy Shevchenko wrote:
> If we don't yet have the platform device for the driver when it is being loaded
> we fail to probe the driver. So instead of calling probe() directly we call
> platform_driver_register(). It will call the probe() immediately if we have the
> device but also makes the driver to work on platforms where the platform device
> is created later.
Why wont you have the platform device? Is this only due to your approach of
creating the device in PCI probe?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/dma/dw_dmac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 476e9c8..b5f21ba 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -1829,6 +1829,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table);
> #endif
>
> static struct platform_driver dw_driver = {
> + .probe = dw_probe,
> .remove = dw_remove,
> .shutdown = dw_shutdown,
> .driver = {
> @@ -1840,7 +1841,7 @@ static struct platform_driver dw_driver = {
>
> static int __init dw_init(void)
> {
> - return platform_driver_probe(&dw_driver, dw_probe);
> + return platform_driver_register(&dw_driver);
> }
> subsys_initcall(dw_init);
>
> --
> 1.7.10.4
>