Re: [resend][PATCH 16/16] dma: dw_dmac: clear suspend bit during termination

Andy Shevchenko
2013-01-09T15:07:50Z

On Wed, Jan 9, 2013 at 4:18 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Jan 09, 2013 at 10:17:15AM +0200, Andy Shevchenko wrote:
>> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>
>> The DMA transfer could not be established if previously it was paused and
>> terminated. In that case the channel's suspend bit remains set that prevents to
>> transfer anything until channel is resumed.
>>
>> The patch adds a code that clears the DWC_CFGL_CH_SUSP bit during termination.
> No this patch calls resume to do so... Can you update the change log

Updated. Will occur in patch v2.

>>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> drivers/dma/dw_dmac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
>> index 6a8f8c7..c6ebea1 100644
>> --- a/drivers/dma/dw_dmac.c
>> +++ b/drivers/dma/dw_dmac.c
>> @@ -1059,7 +1059,7 @@ static int dwc_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
>>
>> dwc_chan_disable(dw, dwc);
>>
>> - dwc->paused = false;
>> + dwc_chan_resume(dwc);
>>
>> /* active_list entries will end up before queued entries */
>> list_splice_init(&dwc->queue, &list);
>> --
>> 1.7.10.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
With Best Regards,
Andy Shevchenko