Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

Vinod Koul
2013-01-09T14:14:29Z

On Wed, Jan 09, 2013 at 10:17:02AM +0200, Andy Shevchenko wrote:
> This function helps to distinguish the slave type of transfer by checking the
> direction parameter.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> include/linux/dmaengine.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 4ca9cf7..b196ea3 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -621,6 +621,11 @@ static inline int dmaengine_slave_config(struct dma_chan *chan,
> (unsigned long)config);
> }
>
> +static inline bool is_slave_xfer(enum dma_transfer_direction direction)
> +{
> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
> +}
After reading the subsequent patch I understand what is intent here. Perhaps
is_slave_dirn() would have been a beter one...

> +
> static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_single(
> struct dma_chan *chan, dma_addr_t buf, size_t len,
> enum dma_transfer_direction dir, unsigned long flags)
> --
> 1.7.10.4
>