public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>, Shawn Guo <shawn.guo@linaro.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Josh Boyer <jwboyer@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	Florian Tobias Schandinat <florianSchandinat@gmx.de>
Subject: Re: [PATCH] fb: Rework locking to fix lock ordering on takeover
Date: Sun, 13 Jan 2013 01:02:42 +0100	[thread overview]
Message-ID: <20130113000242.GD10630@liondog.tnic> (raw)
In-Reply-To: <20130112131323.31d2a585.akpm@linux-foundation.org>

On Sat, Jan 12, 2013 at 01:13:23PM -0800, Andrew Morton wrote:
> Florian has been taking a month or two's downtime (now expired, I
> think) so I've been waiting for him to reappear to process this one for
> 3.8.
> 
> Meanwhile, I guess we could put it into mainline ;) It has been in
> -next for a month.
> 
> From: Alan Cox <alan@linux.intel.com>
> Subject: fb: rework locking to fix lock ordering on takeover
> 
> Adjust the console layer to allow a take over call where the caller
> already holds the locks.  Make the fb layer lock in order.
> 
> This is partly a band aid, the fb layer is terminally confused about the
> locking rules it uses for its notifiers it seems.
> 
> [akpm@linux-foundation.org: remove stray non-ascii char, tidy comment]
> [akpm@linux-foundation.org: export do_take_over_console()]
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Yes, that's the one, modulo Andrew's fixes, which I've been running.
Irregardless, I'll run this one tomorrow just in case, because it
triggers here so easily.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2013-01-13  0:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 19:27 [PATCH] fb: Rework locking to fix lock ordering on takeover Alan Cox
2012-11-21 12:45 ` Josh Boyer
2012-11-21 12:53   ` Alan Cox
2012-12-18 15:20     ` Josh Boyer
2012-12-25 16:08       ` Sasha Levin
2012-12-26  2:41         ` Cong Wang
2012-12-26 18:09           ` Sasha Levin
2012-12-27  4:53             ` Borislav Petkov
2012-12-28 11:50               ` Shawn Guo
2012-12-28 12:40                 ` Borislav Petkov
2013-01-04 12:50                   ` Alexander Holler
2013-01-04 13:25                     ` Alan Cox
2013-01-04 13:36                       ` Alexander Holler
2013-01-05 11:41                         ` Alexander Holler
2013-01-05 11:42                           ` [PATCH] fb: udlfb: fix scheduling while atomic Alexander Holler
2013-01-06 12:46                             ` Alexander Holler
2013-01-09 13:47                               ` [PATCH v2] " Alexander Holler
2013-01-05 12:07                           ` [PATCH] fb: Rework locking to fix lock ordering on takeover Alan Cox
2013-01-05 12:06                             ` Alexander Holler
2013-01-07  9:37                   ` Jiri Kosina
2013-01-12 18:36                     ` Borislav Petkov
2013-01-12 20:51                       ` Linus Torvalds
2013-01-12 21:05                         ` Alan Cox
2013-01-12 21:13                         ` Andrew Morton
2013-01-13  0:02                           ` Borislav Petkov [this message]
2013-01-15 12:06                             ` Maarten Lankhorst
2013-01-15 15:12                               ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130113000242.GD10630@liondog.tnic \
    --to=bp@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=florianSchandinat@gmx.de \
    --cc=jkosina@suse.cz \
    --cc=jwboyer@gmail.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox