* [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig
@ 2013-01-13 3:28 Tiana Rakotovao Andriamahefa
2013-01-13 20:50 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: Tiana Rakotovao Andriamahefa @ 2013-01-13 3:28 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, linux-kernel, Tiana Rakotovao Andriamahefa
When using make xconfig, the following compilation error appears :
/usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
Signed-off-by: Tiana Rakotovao Andriamahefa <rkmahefa@gmail.com>
---
scripts/kconfig/qconf.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index df274fe..1500c38 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -6,6 +6,7 @@
#include <qglobal.h>
#if QT_VERSION < 0x040000
+#include <stddef.h>
#include <qmainwindow.h>
#include <qvbox.h>
#include <qvaluelist.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig
2013-01-13 3:28 [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig Tiana Rakotovao Andriamahefa
@ 2013-01-13 20:50 ` Michal Marek
2013-01-14 0:54 ` Tiana Rakotovao Andriamahefa
0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2013-01-13 20:50 UTC (permalink / raw)
To: Tiana Rakotovao Andriamahefa; +Cc: linux-kbuild, linux-kernel
On 13.1.2013 04:28, Tiana Rakotovao Andriamahefa wrote:
> When using make xconfig, the following compilation error appears :
> /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
> Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
This is a bug in the Qt header. Is Qt3 still maintained?
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig
2013-01-13 20:50 ` Michal Marek
@ 2013-01-14 0:54 ` Tiana Rakotovao Andriamahefa
2013-01-15 21:32 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: Tiana Rakotovao Andriamahefa @ 2013-01-14 0:54 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild, linux-kernel
Le dimanche 13 janvier 2013 à 09:50:52, Michal Marek a écrit :
> On 13.1.2013 04:28, Tiana Rakotovao Andriamahefa wrote:
> > When using make xconfig, the following compilation error appears :
> > /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
> > Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
>
> This is a bug in the Qt header. Is Qt3 still maintained?
This seems to be a common c++ issue since the begining of 2011.
Some Qt3 headers use ptrdiff_t which is defined in stddef.h. They also use some
c++ headers, and rely on them to include stddef.h. However, since GCC-4.6,
those c++ headers do not include stddef.h anymore. So, include <stddef.h>
fixes it.
This issue is reported here: http://gcc.gnu.org/gcc-4.6/porting_to.html?
--
Tiana Rakotovao Andriamahefa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig
2013-01-14 0:54 ` Tiana Rakotovao Andriamahefa
@ 2013-01-15 21:32 ` Michal Marek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2013-01-15 21:32 UTC (permalink / raw)
To: Tiana Rakotovao Andriamahefa; +Cc: linux-kbuild, linux-kernel
On 14.1.2013 01:54, Tiana Rakotovao Andriamahefa wrote:
> Le dimanche 13 janvier 2013 à 09:50:52, Michal Marek a écrit :
>> On 13.1.2013 04:28, Tiana Rakotovao Andriamahefa wrote:
>>> When using make xconfig, the following compilation error appears :
>>> /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
>>> Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
>>
>> This is a bug in the Qt header. Is Qt3 still maintained?
>
> This seems to be a common c++ issue since the begining of 2011.
>
> Some Qt3 headers use ptrdiff_t which is defined in stddef.h. They also use some
> c++ headers, and rely on them to include stddef.h. However, since GCC-4.6,
> those c++ headers do not include stddef.h anymore. So, include <stddef.h>
> fixes it.
Right. My question is - is Qt3 still maintained somehow, so the includes
can be added where they belong, or do we need to workaround in in the
applications?
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig
@ 2013-01-24 16:20 Tiana Rakotovao Andriamahefa
2013-01-30 9:17 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: Tiana Rakotovao Andriamahefa @ 2013-01-24 16:20 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, linux-kernel, rkmahefa
Le jeudi 24 janvier 2013 à 11:36:31, Michal Marek a écrit :
> On 16.1.2013 13:26, Tiana Rakotovao Andriamahefa wrote:
> > I have checked it and found that the error was effectively fixed in the last
> > maintained upload of Qt3 in 2011. However, the correction is not yet in Wheezy
> > (Debian testing) which I have used for more than a year. It might be
> > included there one day!
> > This is the case of Debian, but not all distros.
>
> OK. And it is dead upstream. So I'll apply your patch. Could you please
> resend it? I deleted the email already.
Here is the patch.
When using make xconfig, the following compilation error appears :
/usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
Signed-off-by: Tiana Rakotovao Andriamahefa <rkmahefa@gmail.com>
---
scripts/kconfig/qconf.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index df274fe..1500c38 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -6,6 +6,7 @@
#include <qglobal.h>
#if QT_VERSION < 0x040000
+#include <stddef.h>
#include <qmainwindow.h>
#include <qvbox.h>
#include <qvaluelist.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig
2013-01-24 16:20 Tiana Rakotovao Andriamahefa
@ 2013-01-30 9:17 ` Michal Marek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2013-01-30 9:17 UTC (permalink / raw)
To: Tiana Rakotovao Andriamahefa; +Cc: linux-kbuild, linux-kernel
On Thu, Jan 24, 2013 at 04:20:39PM +0000, Tiana Rakotovao Andriamahefa wrote:
> Le jeudi 24 janvier 2013 à 11:36:31, Michal Marek a écrit :
> > On 16.1.2013 13:26, Tiana Rakotovao Andriamahefa wrote:
> > > I have checked it and found that the error was effectively fixed in the last
> > > maintained upload of Qt3 in 2011. However, the correction is not yet in Wheezy
> > > (Debian testing) which I have used for more than a year. It might be
> > > included there one day!
> > > This is the case of Debian, but not all distros.
> >
> > OK. And it is dead upstream. So I'll apply your patch. Could you please
> > resend it? I deleted the email already.
>
> Here is the patch.
>
> When using make xconfig, the following compilation error appears :
> /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
> Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
>
> Signed-off-by: Tiana Rakotovao Andriamahefa <rkmahefa@gmail.com>
Thanks, applied to kbuild.git#kconfig.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-30 9:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-13 3:28 [PATCH] scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig Tiana Rakotovao Andriamahefa
2013-01-13 20:50 ` Michal Marek
2013-01-14 0:54 ` Tiana Rakotovao Andriamahefa
2013-01-15 21:32 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2013-01-24 16:20 Tiana Rakotovao Andriamahefa
2013-01-30 9:17 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).