From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756841Ab3ANL0Y (ORCPT ); Mon, 14 Jan 2013 06:26:24 -0500 Received: from mail.skyhub.de ([78.46.96.112]:56650 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756420Ab3ANL0V (ORCPT ); Mon, 14 Jan 2013 06:26:21 -0500 Date: Mon, 14 Jan 2013 12:26:19 +0100 From: Borislav Petkov To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , Jan Kiszka , Jason Wessel , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7u1 24/31] x86, boot: Not need to check setup_header version for setup_data Message-ID: <20130114112619.GG1228@liondog.tnic> Mail-Followup-To: Borislav Petkov , Yinghai Lu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , Jan Kiszka , Jason Wessel , linux-kernel@vger.kernel.org References: <1357260531-11115-1-git-send-email-yinghai@kernel.org> <1357260531-11115-25-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1357260531-11115-25-git-send-email-yinghai@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 03, 2013 at 04:48:44PM -0800, Yinghai Lu wrote: > That is for bootloader. > > setup_data is in setup_header, and all bootloader is copying that > for bzImage. So for old bootloader should keep that as 0. Are you sure all old bootloaders have kept setup_data as 0 so that you can drop the check. And besides, the check doesn't hurt but prevents insane old boot loaders from handing in crap into the kernel so I'd leave it in. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --