From: Greg KH <gregkh@linuxfoundation.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
arnd@arndb.de, alan@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking
Date: Mon, 14 Jan 2013 06:32:38 -0800 [thread overview]
Message-ID: <20130114143238.GC20384@kroah.com> (raw)
In-Reply-To: <CA+icZUXa-cgNPTYAKjXDSkoqNhto7jz89yUMJAvYxa-jGtMbjg@mail.gmail.com>
On Mon, Jan 14, 2013 at 03:14:50PM +0100, Sedat Dilek wrote:
> On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> > On systems where wd and amthif is not initialized
> > we will hit cl->dev == NULL. This condition is okay
> > so we don't need to be laud about it.
> >
> > Fixes the follwing warning during suspend
> > [ 137.061985] WARNING: at drivers/misc/mei/client.c:315 mei_cl_unlink+0x86/0x90 [mei]()
> > [ 137.061986] Hardware name: 530U3BI/530U4BI/530U4BH
> > [ 137.062140] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek joydev coretemp kvm_intel snd_hda_intel snd_hda_codec kvm arc4 iwldvm snd_hwdep i915 snd_pcm mac80211 ghash_clmulni_intel snd_page_alloc aesni_intel snd_seq_midi xts snd_seq_midi_event aes_x86_64 rfcomm snd_rawmidi parport_pc bnep lrw snd_seq uvcvideo i2c_algo_bit ppdev gf128mul iwlwifi snd_timer drm_kms_helper ablk_helper cryptd drm snd_seq_device videobuf2_vmalloc psmouse videobuf2_memops snd cfg80211 btusb videobuf2_core soundcore videodev lp bluetooth samsung_laptop wmi microcode mei serio_raw mac_hid video hid_generic lpc_ich parport usbhid hid r8169
> > [ 137.062143] Pid: 2706, comm: kworker/u:15 Tainted: G D W 3.8.0-rc2-next20130109-1-iniza-generic #1
> > [ 137.062144] Call Trace:
> > [ 137.062156] [<ffffffff8105860f>] warn_slowpath_common+0x7f/0xc0
> > [ 137.062159] [<ffffffff8135b1ea>] ? ioread32+0x3a/0x40
> > [ 137.062162] [<ffffffff8105866a>] warn_slowpath_null+0x1a/0x20
> > [ 137.062168] [<ffffffffa0076be6>] mei_cl_unlink+0x86/0x90 [mei]
> > [ 137.062173] [<ffffffffa0071325>] mei_reset+0xc5/0x240 [mei]
> > [ 137.062178] [<ffffffffa0073703>] mei_pci_resume+0xa3/0x110 [mei]
> > [ 137.062183] [<ffffffff81379cae>] pci_pm_resume+0x7e/0xe0
> > [ 137.062185] [<ffffffff81379c30>] ? pci_pm_thaw+0x80/0x80
> > [ 137.062189] [<ffffffff8145a415>] dpm_run_callback.isra.6+0x25/0x50
> > [ 137.062192] [<ffffffff8145a6cf>] device_resume+0x9f/0x140
> > [ 137.062194] [<ffffffff8145a791>] async_resume+0x21/0x50
> > [ 137.062200] [<ffffffff810858b0>] async_run_entry_fn+0x90/0x1c0
> > [ 137.062203] [<ffffffff810778e5>] process_one_work+0x155/0x460
> > [ 137.062207] [<ffffffff81078578>] worker_thread+0x168/0x400
> > [ 137.062210] [<ffffffff81078410>] ? manage_workers+0x2b0/0x2b0
> > [ 137.062214] [<ffffffff8107d9f0>] kthread+0xc0/0xd0
> > [ 137.062218] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
> > [ 137.062222] [<ffffffff816bac6c>] ret_from_fork+0x7c/0xb0
> > [ 137.062228] [<ffffffff8107d930>] ? flush_kthread_worker+0xb0/0xb0
> >
> > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Can you please apply this patch to char-misc-next?
> I am hitting it again while doing other regression testing!
Please be patient, it will get there soon.
greg k-h
next prev parent reply other threads:[~2013-01-14 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 15:32 [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking Tomas Winkler
2013-01-14 14:14 ` Sedat Dilek
2013-01-14 14:32 ` Greg KH [this message]
2013-01-14 14:55 ` Sedat Dilek
2013-01-14 15:12 ` Greg KH
2013-01-14 15:34 ` Sedat Dilek
2013-01-15 1:46 ` Chen Gang F T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114143238.GC20384@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox