From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757203Ab3ANObv (ORCPT ); Mon, 14 Jan 2013 09:31:51 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:37723 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755913Ab3ANObu (ORCPT ); Mon, 14 Jan 2013 09:31:50 -0500 Date: Mon, 14 Jan 2013 06:32:38 -0800 From: Greg KH To: Sedat Dilek Cc: Tomas Winkler , arnd@arndb.de, alan@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [char-misc-next V2] mei: drop the warning when cl is not initialized during unlinking Message-ID: <20130114143238.GC20384@kroah.com> References: <1357831934-31610-1-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 14, 2013 at 03:14:50PM +0100, Sedat Dilek wrote: > On Thu, Jan 10, 2013 at 4:32 PM, Tomas Winkler wrote: > > On systems where wd and amthif is not initialized > > we will hit cl->dev == NULL. This condition is okay > > so we don't need to be laud about it. > > > > Fixes the follwing warning during suspend > > [ 137.061985] WARNING: at drivers/misc/mei/client.c:315 mei_cl_unlink+0x86/0x90 [mei]() > > [ 137.061986] Hardware name: 530U3BI/530U4BI/530U4BH > > [ 137.062140] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek joydev coretemp kvm_intel snd_hda_intel snd_hda_codec kvm arc4 iwldvm snd_hwdep i915 snd_pcm mac80211 ghash_clmulni_intel snd_page_alloc aesni_intel snd_seq_midi xts snd_seq_midi_event aes_x86_64 rfcomm snd_rawmidi parport_pc bnep lrw snd_seq uvcvideo i2c_algo_bit ppdev gf128mul iwlwifi snd_timer drm_kms_helper ablk_helper cryptd drm snd_seq_device videobuf2_vmalloc psmouse videobuf2_memops snd cfg80211 btusb videobuf2_core soundcore videodev lp bluetooth samsung_laptop wmi microcode mei serio_raw mac_hid video hid_generic lpc_ich parport usbhid hid r8169 > > [ 137.062143] Pid: 2706, comm: kworker/u:15 Tainted: G D W 3.8.0-rc2-next20130109-1-iniza-generic #1 > > [ 137.062144] Call Trace: > > [ 137.062156] [] warn_slowpath_common+0x7f/0xc0 > > [ 137.062159] [] ? ioread32+0x3a/0x40 > > [ 137.062162] [] warn_slowpath_null+0x1a/0x20 > > [ 137.062168] [] mei_cl_unlink+0x86/0x90 [mei] > > [ 137.062173] [] mei_reset+0xc5/0x240 [mei] > > [ 137.062178] [] mei_pci_resume+0xa3/0x110 [mei] > > [ 137.062183] [] pci_pm_resume+0x7e/0xe0 > > [ 137.062185] [] ? pci_pm_thaw+0x80/0x80 > > [ 137.062189] [] dpm_run_callback.isra.6+0x25/0x50 > > [ 137.062192] [] device_resume+0x9f/0x140 > > [ 137.062194] [] async_resume+0x21/0x50 > > [ 137.062200] [] async_run_entry_fn+0x90/0x1c0 > > [ 137.062203] [] process_one_work+0x155/0x460 > > [ 137.062207] [] worker_thread+0x168/0x400 > > [ 137.062210] [] ? manage_workers+0x2b0/0x2b0 > > [ 137.062214] [] kthread+0xc0/0xd0 > > [ 137.062218] [] ? flush_kthread_worker+0xb0/0xb0 > > [ 137.062222] [] ret_from_fork+0x7c/0xb0 > > [ 137.062228] [] ? flush_kthread_worker+0xb0/0xb0 > > > > Reported-by: Sedat Dilek > > Tested-by: Sedat Dilek > > Signed-off-by: Tomas Winkler > > Can you please apply this patch to char-misc-next? > I am hitting it again while doing other regression testing! Please be patient, it will get there soon. greg k-h