From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758859Ab3ANVO5 (ORCPT ); Mon, 14 Jan 2013 16:14:57 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:45161 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757605Ab3ANVO4 (ORCPT ); Mon, 14 Jan 2013 16:14:56 -0500 X-Greylist: delayed 494 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Jan 2013 16:14:56 EST Date: Mon, 14 Jan 2013 21:06:37 +0000 From: James Hogan To: Namjae Jeon Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] NULL pointer dereference in udf_sb_free_partitions Message-ID: <20130114210637.GA2122@balrog> References: <20130112220015.GA2387@balrog> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jan 14, 2013 at 02:19:39PM +0900, Namjae Jeon wrote: > There is missing exception handling in memory leak patch. (udf: Fix > memory leak when mounting) > So, Would you try to reproduce this problem with the below patch ? > > Thanks. > > --------------------------------------------------------------------------- > Subject: [PATCH] UDF: Fix a null pointer dereference in udf_sb_free_partitions > > This patch fixes a regression caused by commit bff943af6fe > "udf: Fix memory leak when mounting" due to which it was triggering > a kernel null point dereference in case of mount failed OR when allocating > memory to sbi->s_partmaps failed in function udf_sb_alloc_partition_maps. > > Reported-by: James Hogan > Signed-off-by: Namjae Jeon > Signed-off-by: Ashish Sangwan v3.8-rc3 + your patch no longer crashes. Tested-by: James Hogan Thanks James