[PATCH] clk: remove exported function from __init section

[PATCH] clk: remove exported function from __init section

[Denis Efremov]

The symbol of_fixed_clk_setup is exported and annotated __init.
This looks like section mismatch.
Fix this by removing the __init annotation of of_fixed_clk_setup.

Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
 drivers/clk/clk-fixed-rate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
index af78ed6..a53b53b 100644
--- a/drivers/clk/clk-fixed-rate.c
+++ b/drivers/clk/clk-fixed-rate.c
@@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void __init of_fixed_clk_setup(struct device_node *node)
+void of_fixed_clk_setup(struct device_node *node)
 {
 	struct clk *clk;
 	const char *clk_name = node->name;
-- 
1.7.10.4

Re: [PATCH] clk: remove exported function from __init section

[Rob Herring]

On 01/06/2013 08:21 AM, Denis Efremov wrote:
> The symbol of_fixed_clk_setup is exported and annotated __init.
> This looks like section mismatch.
> Fix this by removing the __init annotation of of_fixed_clk_setup.
> 
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>

Mike should take this.

Acked-by: Rob Herring <rob.herring@calxeda.com>

> ---
>  drivers/clk/clk-fixed-rate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index af78ed6..a53b53b 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
>  /**
>   * of_fixed_clk_setup() - Setup function for simple fixed rate clock
>   */
> -void __init of_fixed_clk_setup(struct device_node *node)
> +void of_fixed_clk_setup(struct device_node *node)
>  {
>  	struct clk *clk;
>  	const char *clk_name = node->name;
> 

Re: [PATCH] clk: remove exported function from __init section

[Mike Turquette]

Quoting Rob Herring (2013-01-06 06:58:40)
> On 01/06/2013 08:21 AM, Denis Efremov wrote:
> > The symbol of_fixed_clk_setup is exported and annotated __init.
> > This looks like section mismatch.
> > Fix this by removing the __init annotation of of_fixed_clk_setup.
> > 
> > Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
> 
> Mike should take this.
> 
> Acked-by: Rob Herring <rob.herring@calxeda.com>
>

Thanks for catching this Denis.  Taken into clk-next.

Regards,
Mike
 
> > ---
> >  drivers/clk/clk-fixed-rate.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> > index af78ed6..a53b53b 100644
> > --- a/drivers/clk/clk-fixed-rate.c
> > +++ b/drivers/clk/clk-fixed-rate.c
> > @@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
> >  /**
> >   * of_fixed_clk_setup() - Setup function for simple fixed rate clock
> >   */
> > -void __init of_fixed_clk_setup(struct device_node *node)
> > +void of_fixed_clk_setup(struct device_node *node)
> >  {
> >       struct clk *clk;
> >       const char *clk_name = node->name;
> >