* [PATCH] clk: remove exported function from __init section
@ 2013-01-06 14:21 Denis Efremov
2013-01-06 14:58 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Denis Efremov @ 2013-01-06 14:21 UTC (permalink / raw)
To: Grant Likely; +Cc: Denis Efremov, Mike Turquette, Rob Herring, linux-kernel
The symbol of_fixed_clk_setup is exported and annotated __init.
This looks like section mismatch.
Fix this by removing the __init annotation of of_fixed_clk_setup.
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
drivers/clk/clk-fixed-rate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
index af78ed6..a53b53b 100644
--- a/drivers/clk/clk-fixed-rate.c
+++ b/drivers/clk/clk-fixed-rate.c
@@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
/**
* of_fixed_clk_setup() - Setup function for simple fixed rate clock
*/
-void __init of_fixed_clk_setup(struct device_node *node)
+void of_fixed_clk_setup(struct device_node *node)
{
struct clk *clk;
const char *clk_name = node->name;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: remove exported function from __init section
2013-01-06 14:21 [PATCH] clk: remove exported function from __init section Denis Efremov
@ 2013-01-06 14:58 ` Rob Herring
2013-01-14 23:34 ` Mike Turquette
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2013-01-06 14:58 UTC (permalink / raw)
To: Denis Efremov; +Cc: Grant Likely, Mike Turquette, linux-kernel
On 01/06/2013 08:21 AM, Denis Efremov wrote:
> The symbol of_fixed_clk_setup is exported and annotated __init.
> This looks like section mismatch.
> Fix this by removing the __init annotation of of_fixed_clk_setup.
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Mike should take this.
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/clk/clk-fixed-rate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index af78ed6..a53b53b 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
> /**
> * of_fixed_clk_setup() - Setup function for simple fixed rate clock
> */
> -void __init of_fixed_clk_setup(struct device_node *node)
> +void of_fixed_clk_setup(struct device_node *node)
> {
> struct clk *clk;
> const char *clk_name = node->name;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: remove exported function from __init section
2013-01-06 14:58 ` Rob Herring
@ 2013-01-14 23:34 ` Mike Turquette
0 siblings, 0 replies; 3+ messages in thread
From: Mike Turquette @ 2013-01-14 23:34 UTC (permalink / raw)
To: Rob Herring, Denis Efremov; +Cc: Grant Likely, linux-kernel
Quoting Rob Herring (2013-01-06 06:58:40)
> On 01/06/2013 08:21 AM, Denis Efremov wrote:
> > The symbol of_fixed_clk_setup is exported and annotated __init.
> > This looks like section mismatch.
> > Fix this by removing the __init annotation of of_fixed_clk_setup.
> >
> > Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
>
> Mike should take this.
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
>
Thanks for catching this Denis. Taken into clk-next.
Regards,
Mike
> > ---
> > drivers/clk/clk-fixed-rate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> > index af78ed6..a53b53b 100644
> > --- a/drivers/clk/clk-fixed-rate.c
> > +++ b/drivers/clk/clk-fixed-rate.c
> > @@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
> > /**
> > * of_fixed_clk_setup() - Setup function for simple fixed rate clock
> > */
> > -void __init of_fixed_clk_setup(struct device_node *node)
> > +void of_fixed_clk_setup(struct device_node *node)
> > {
> > struct clk *clk;
> > const char *clk_name = node->name;
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-14 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-06 14:21 [PATCH] clk: remove exported function from __init section Denis Efremov
2013-01-06 14:58 ` Rob Herring
2013-01-14 23:34 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox