* [PATCH]iommu: Include linux/err.h
@ 2012-12-13 16:55 Wang YanQing
2012-12-13 17:15 ` Alex Williamson
0 siblings, 1 reply; 6+ messages in thread
From: Wang YanQing @ 2012-12-13 16:55 UTC (permalink / raw)
To: joerg.roedel; +Cc: linux-kernel, alex.williamson
The linux/iommu.h header uses ERR_PTR defined
in linux/err.h but doesn't include it.
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
include/linux/iommu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index f3b99e1..f4a49a6 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
#define __LINUX_IOMMU_H
#include <linux/errno.h>
+#include <linux/err.h>
#include <linux/types.h>
#define IOMMU_READ (1)
--
1.7.11.1.116.g8228a23
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH]iommu: Include linux/err.h
2012-12-13 16:55 [PATCH]iommu: Include linux/err.h Wang YanQing
@ 2012-12-13 17:15 ` Alex Williamson
2013-01-15 1:09 ` Wang YanQing
0 siblings, 1 reply; 6+ messages in thread
From: Alex Williamson @ 2012-12-13 17:15 UTC (permalink / raw)
To: Wang YanQing; +Cc: joerg.roedel, linux-kernel
On Fri, 2012-12-14 at 00:55 +0800, Wang YanQing wrote:
> The linux/iommu.h header uses ERR_PTR defined
> in linux/err.h but doesn't include it.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
> include/linux/iommu.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index f3b99e1..f4a49a6 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -20,6 +20,7 @@
> #define __LINUX_IOMMU_H
>
> #include <linux/errno.h>
> +#include <linux/err.h>
> #include <linux/types.h>
>
> #define IOMMU_READ (1)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH]iommu: Include linux/err.h
2012-12-13 17:15 ` Alex Williamson
@ 2013-01-15 1:09 ` Wang YanQing
0 siblings, 0 replies; 6+ messages in thread
From: Wang YanQing @ 2013-01-15 1:09 UTC (permalink / raw)
To: joro; +Cc: joerg.roedel, linux-kernel, alex.williamson
On Thu, Dec 13, 2012 at 10:15:38AM -0700, Alex Williamson wrote:
> On Fri, 2012-12-14 at 00:55 +0800, Wang YanQing wrote:
> > The linux/iommu.h header uses ERR_PTR defined
> > in linux/err.h but doesn't include it.
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> > include/linux/iommu.h | 1 +
> > 1 file changed, 1 insertion(+)
>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
>
> > diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> > index f3b99e1..f4a49a6 100644
> > --- a/include/linux/iommu.h
> > +++ b/include/linux/iommu.h
> > @@ -20,6 +20,7 @@
> > #define __LINUX_IOMMU_H
> >
> > #include <linux/errno.h>
> > +#include <linux/err.h>
> > #include <linux/types.h>
> >
> > #define IOMMU_READ (1)
>
>
Hi Joerg Roedel, maybe you are saturated by
Emails, and miss it.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH]iommu: Include linux/err.h
@ 2013-02-25 14:48 Wang YanQing
0 siblings, 0 replies; 6+ messages in thread
From: Wang YanQing @ 2013-02-25 14:48 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, alex.williamson, joerg.roedel
The linux/iommu.h header uses ERR_PTR defined
in linux/err.h but doesn't include it.
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
I send this twice to joerg.roedel@amd.com more than one
month, but it had been ignored, I don't why.
include/linux/iommu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index f3b99e1..f4a49a6 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
#define __LINUX_IOMMU_H
#include <linux/errno.h>
+#include <linux/err.h>
#include <linux/types.h>
#define IOMMU_READ (1)
--
1.7.11.1.116.g8228a23
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] iommu: Include linux/err.h
@ 2013-04-19 1:38 Wang YanQing
2013-04-19 19:13 ` Joerg Roedel
0 siblings, 1 reply; 6+ messages in thread
From: Wang YanQing @ 2013-04-19 1:38 UTC (permalink / raw)
To: dwmw2; +Cc: linux-kernel, joro, alex.williamson
The linux/iommu.h header uses ERR_PTR defined
in linux/err.h but doesn't include it.
Cc:joro@8bytes.org
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
This patch has been in LKML for more than 2 months,
I even forget it, but the compile error when I compile
a kernel module for 3.8.8 failed due without CONFIG_IOMMU_API
in my .config remind me.
I really hope someone accept it.
Thanks.
include/linux/iommu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index f3b99e1..f4a49a6 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
#define __LINUX_IOMMU_H
#include <linux/errno.h>
+#include <linux/err.h>
#include <linux/types.h>
#define IOMMU_READ (1)
--
1.7.12.4.dirty
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iommu: Include linux/err.h
2013-04-19 1:38 [PATCH] iommu: " Wang YanQing
@ 2013-04-19 19:13 ` Joerg Roedel
0 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2013-04-19 19:13 UTC (permalink / raw)
To: Wang YanQing, dwmw2, linux-kernel, alex.williamson
On Fri, Apr 19, 2013 at 09:38:04AM +0800, Wang YanQing wrote:
> The linux/iommu.h header uses ERR_PTR defined
> in linux/err.h but doesn't include it.
>
> Cc:joro@8bytes.org
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Applied to core branch, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-19 19:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-13 16:55 [PATCH]iommu: Include linux/err.h Wang YanQing
2012-12-13 17:15 ` Alex Williamson
2013-01-15 1:09 ` Wang YanQing
-- strict thread matches above, loose matches on Subject: below --
2013-02-25 14:48 Wang YanQing
2013-04-19 1:38 [PATCH] iommu: " Wang YanQing
2013-04-19 19:13 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox