Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property

Doug Anderson
2013-01-10T23:23:09Z

Olof,

Thanks for your comments.

On Thu, Jan 10, 2013 at 3:01 PM, Olof Johansson <olof@lixom.net> wrote:
>
> The previous code used the controller-common quirk field to set a
> per-controller DW_MCI_QUIRK_NO_WRITE_PROTECT. Is there really need to
> do this per-slot? And if so, please explain in the commit message why
> there is need for a brand new quirk for the same functionality.

I'm happy to move back to using a per-controller quirk here--it
simplifies the code quite a bit since it can use all of the
preexisting quirks code. I originally coded it up as per-slot since
generally each slot needs its own write-protect line. Without ever
seeing any hardware using multiple slots per controller I can't say
how common this would be, so it may be overkill to handle that
situation.

Note that I think of the new code as being the device-tree equivalent
of the non-device-tree "brd->get_ro(slot_id)" function. That function
is per-slot.

I will wait a day or two to see if others have feedback. If I hear no
feedback I'll send up a patch that moves this to be at the controller
level.

Thanks!

-Doug