From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Cong Ding <dinggnu@gmail.com>
Cc: Mikael Starvik <starvik@axis.com>,
linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cris: arch-v32/drivers/sync_serial.c: fix error macro position
Date: Tue, 15 Jan 2013 10:34:18 +0100 [thread overview]
Message-ID: <20130115093418.GH23529@axis.com> (raw)
In-Reply-To: <1358199990-15905-1-git-send-email-dinggnu@gmail.com>
On Mon, Jan 14, 2013 at 10:46:28PM +0100, Cong Ding wrote:
> the macro CONFIG_ETRAXFS is used in wrong position - all the port[1] related
> stuff should be used only when CONFIG_ETRAXFS is enabled.
Problem should not be possible to see unless you enable
CONFIG_ETRAX_SYNCHRONOUS_SERIAL_PORT1 also, which has
depends on ETRAX_SYNCHRONOUS_SERIAL && ETRAXFS
in the Kconfig...
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
...But anyways, the hardware doesn't have the second synchronous serial port
for ARTPEC-3, so for clarity I'll take this in the CRIS tree. My thanks.
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2013-01-15 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 21:46 [PATCH] cris: arch-v32/drivers/sync_serial.c: fix error macro position Cong Ding
2013-01-15 9:34 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115093418.GH23529@axis.com \
--to=jesper.nilsson@axis.com \
--cc=dinggnu@gmail.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox