[PATCH] usb: phy: remove unused APIs from Tegra PHY.

[PATCH] usb: phy: remove unused APIs from Tegra PHY.

[Venu Byravarasu]

As tegra_usb_phy_clk_disable/enable() are not being
used, removing them.

Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
 drivers/usb/phy/tegra_usb_phy.c   |   13 -------------
 include/linux/usb/tegra_usb_phy.h |    4 ----
 2 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
index 2d3cae9..3059384 100644
--- a/drivers/usb/phy/tegra_usb_phy.c
+++ b/drivers/usb/phy/tegra_usb_phy.c
@@ -825,16 +825,3 @@ void tegra_ehci_phy_restore_end(struct tegra_usb_phy *phy)
 }
 EXPORT_SYMBOL_GPL(tegra_ehci_phy_restore_end);
 
-void tegra_usb_phy_clk_disable(struct tegra_usb_phy *phy)
-{
-	if (!phy_is_ulpi(phy))
-		utmi_phy_clk_disable(phy);
-}
-EXPORT_SYMBOL_GPL(tegra_usb_phy_clk_disable);
-
-void tegra_usb_phy_clk_enable(struct tegra_usb_phy *phy)
-{
-	if (!phy_is_ulpi(phy))
-		utmi_phy_clk_enable(phy);
-}
-EXPORT_SYMBOL_GPL(tegra_usb_phy_clk_enable);
diff --git a/include/linux/usb/tegra_usb_phy.h b/include/linux/usb/tegra_usb_phy.h
index 176b1ca..34e6355 100644
--- a/include/linux/usb/tegra_usb_phy.h
+++ b/include/linux/usb/tegra_usb_phy.h
@@ -64,10 +64,6 @@ struct tegra_usb_phy {
 struct tegra_usb_phy *tegra_usb_phy_open(struct device *dev, int instance,
 	void __iomem *regs, void *config, enum tegra_usb_phy_mode phy_mode);
 
-void tegra_usb_phy_clk_disable(struct tegra_usb_phy *phy);
-
-void tegra_usb_phy_clk_enable(struct tegra_usb_phy *phy);
-
 void tegra_usb_phy_preresume(struct tegra_usb_phy *phy);
 
 void tegra_usb_phy_postresume(struct tegra_usb_phy *phy);
-- 
1.7.0.4

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

[Stephen Warren]

On 01/15/2013 03:19 AM, Venu Byravarasu wrote:
> As tegra_usb_phy_clk_disable/enable() are not being
> used, removing them.

Greg, Felipe,

Again if I may, I'll take this through the Tegra tree. I think the next
set of patches that Venu posts should actually expose the dependencies
between his USB patches and the Tegra clock framework rework, which are
why I want to do this.

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

[Greg KH]

On Tue, Jan 15, 2013 at 11:04:51AM -0700, Stephen Warren wrote:
> On 01/15/2013 03:19 AM, Venu Byravarasu wrote:
> > As tegra_usb_phy_clk_disable/enable() are not being
> > used, removing them.
> 
> Greg, Felipe,
> 
> Again if I may, I'll take this through the Tegra tree. I think the next
> set of patches that Venu posts should actually expose the dependencies
> between his USB patches and the Tegra clock framework rework, which are
> why I want to do this.

I'll let Felipe judge these, as they are in his area, it's up to him.

greg k-h

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Hi,

On Tue, Jan 15, 2013 at 11:04:51AM -0700, Stephen Warren wrote:
> On 01/15/2013 03:19 AM, Venu Byravarasu wrote:
> > As tegra_usb_phy_clk_disable/enable() are not being
> > used, removing them.
> 
> Greg, Felipe,
> 
> Again if I may, I'll take this through the Tegra tree. I think the next
> set of patches that Venu posts should actually expose the dependencies
> between his USB patches and the Tegra clock framework rework, which are
> why I want to do this.

that should be ok:

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

[Stephen Warren]

On 01/16/2013 12:12 AM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Jan 15, 2013 at 11:04:51AM -0700, Stephen Warren wrote:
>> On 01/15/2013 03:19 AM, Venu Byravarasu wrote:
>>> As tegra_usb_phy_clk_disable/enable() are not being used,
>>> removing them.
>> 
>> Greg, Felipe,
>> 
>> Again if I may, I'll take this through the Tegra tree. I think
>> the next set of patches that Venu posts should actually expose
>> the dependencies between his USB patches and the Tegra clock
>> framework rework, which are why I want to do this.
> 
> that should be ok:
> 
> Acked-by: Felipe Balbi <balbi@ti.com>

Thanks. I've applied this to Tegra's for-3.9/usb branch.

BTW Venu, you forgot to Cc the linux-tegra mailing list; that's
probably more useful than linux-kernel for Tegra-specific driver changes.