From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] regmap: debugfs: Fix last entry store in the offset cache
Date: Wed, 16 Jan 2013 22:29:19 +0900 [thread overview]
Message-ID: <20130116132918.GH25480@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1358342651-19690-1-git-send-email-p.zabel@pengutronix.de>
On Wed, Jan 16, 2013 at 02:24:11PM +0100, Philipp Zabel wrote:
> - /* Close the last entry off if we didn't scan beyond it */
> - if (c) {
> - c->max = p - 1;
> - list_add_tail(&c->list,
> - &map->debugfs_off_cache);
Oh, ffs. I actually fixed this but the cherry pick went wrong.
> - } else {
> - return base;
> + /* Close the last entry off if we didn't scan beyond it */
> + if (c) {
> + c->max = p - 1;
> + list_add_tail(&c->list,
> + &map->debugfs_off_cache);
> + } else {
> + return base;
> + }
No, the else clause just needs deleting.
prev parent reply other threads:[~2013-01-16 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 13:24 [PATCH] regmap: debugfs: Fix last entry store in the offset cache Philipp Zabel
2013-01-16 13:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116132918.GH25480@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox