From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756567Ab3APSOY (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Jan 2013 13:14:24 -0500
Received: from mail-yh0-f51.google.com ([209.85.213.51]:37073 "EHLO
	mail-yh0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753445Ab3APSOX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Jan 2013 13:14:23 -0500
Date: Wed, 16 Jan 2013 15:14:16 -0300
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Paul Mackerras <paulus@samba.org>,
        Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Stephane Eranian <eranian@google.com>,
        Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 06/13] perf ui/hist: Add support for event group view
Message-ID: <20130116181416.GM5826@ghostprotocols.net>
References: <1358235117-12803-1-git-send-email-namhyung@kernel.org>
 <1358235117-12803-7-git-send-email-namhyung@kernel.org>
 <20130115183110.GB5826@ghostprotocols.net>
 <87ip6xmqhi.fsf@sejong.aot.lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ip6xmqhi.fsf@sejong.aot.lge.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Jan 16, 2013 at 06:22:49PM +0900, Namhyung Kim escreveu:
> On Tue, 15 Jan 2013 15:31:10 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 15, 2013 at 04:31:50PM +0900, Namhyung Kim escreveu:
> >> From: Namhyung Kim <namhyung.kim@lge.com>
> >> 
> >> Show group members' overhead also when showing the leader's if event
> >> group is enabled.  Use macro for defining hpp functions which looks
> >> almost identical.
> >> 
> >> Thanks to Arnaldo for suggesting a better way to print group members
> >> without allocating temporary array.
> >
> > Thanks! Its a pity the patch ended up mixing up things, I'll have to
> > apply it and look at the end result.
> 
> Do you mean I have to separate this into two - one for converting to
> macro and another for event group view itself?

If you can, please, that way we may see more clearly each of these
changes in the separated patches.

Thanks,

- Arnaldo