From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Cox <alan@linux.intel.com>
Cc: Jiri Slaby <jslaby@suse.cz>, Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, gaowanlong@cn.fujitsu.com,
frank@lichtenheld.de
Subject: Re: regression, bisected: openpty fails from 3.7 onwards without devpts
Date: Thu, 17 Jan 2013 08:29:24 -0800 [thread overview]
Message-ID: <20130117162924.GC1396@kroah.com> (raw)
In-Reply-To: <20130111131802.2986ba61@bob.linux.org.uk>
On Fri, Jan 11, 2013 at 01:18:02PM +0000, Alan Cox wrote:
> On Fri, 11 Jan 2013 13:44:22 +0100
> Jiri Slaby <jslaby@suse.cz> wrote:
>
> > On 01/11/2013 01:41 PM, Florian Westphal wrote:
> > > Jiri Slaby <jslaby@suse.cz> wrote:
> > >> On 01/10/2013 11:51 PM, Jiri Slaby wrote:
> > >>> On 01/10/2013 11:45 PM, Alan Cox wrote:
> > >>>> So we should just fix TIOCGPTN on a pty with no suitable name
> > >>>> answer to return -EINVAL
> > >>>
> > >>> Yes, I agree as I'm expressed in my second mail. Sorry for the
> > >>> confusion.
> > >>
> > >> Does the attached patch help?
> > >
> > > Yes, it does. Thanks for fixing this.
> >
> > Ok, now I'm not sure if we want the patch or to implement TIOCGPTN
> > properly instead. Alan?
>
> IMHO - fix now for the -rc tree where its clearly low risk, after that
> whatever people feel like doing 8)
I agree. Jiri, should I take your posted patch for this?
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-17 16:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 14:46 regression, bisected: openpty fails from 3.7 onwards without devpts Florian Westphal
2013-01-10 15:50 ` Alan Cox
2013-01-10 16:29 ` Florian Westphal
2013-01-10 17:23 ` Jiri Slaby
2013-01-10 20:13 ` Jiri Slaby
2013-01-10 22:45 ` Alan Cox
2013-01-10 22:51 ` Jiri Slaby
2013-01-11 11:11 ` Jiri Slaby
2013-01-11 12:41 ` Florian Westphal
2013-01-11 12:44 ` Jiri Slaby
2013-01-11 13:18 ` Alan Cox
2013-01-17 16:29 ` Greg KH [this message]
2013-01-17 16:34 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117162924.GC1396@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=frank@lichtenheld.de \
--cc=fw@strlen.de \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox