From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: linux-kernel@vger.kernel.org, Matt Porter <mporter@ti.com>,
Russ Dill <Russ.Dill@ti.com>,
Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH] platform: Fix platform device resource linking
Date: Thu, 17 Jan 2013 08:31:59 -0800 [thread overview]
Message-ID: <20130117163159.GD1396@kroah.com> (raw)
In-Reply-To: <CD23CDD8-5740-4649-8876-ADDFCFF30C35@antoniou-consulting.com>
On Fri, Jan 04, 2013 at 12:43:46AM +0200, Pantelis Antoniou wrote:
> Hi Greg,
>
> On Jan 4, 2013, at 12:40 AM, Greg Kroah-Hartman wrote:
>
> > On Fri, Jan 04, 2013 at 12:31:10AM +0200, Pantelis Antoniou wrote:
> >> Platform device removal uncovered a number of problems with
> >> the way resources are handled in the core platform code.
> >>
> >> Resources now form child/parent linkages and this requires
> >> proper linking of the resources. On top of that the OF core
> >> directly creates it's own platform devices. Simplify things
> >> by providing helper functions that manage the linking properly.
> >>
> >> Two functions are provided:
> >>
> >> platform_device_link_resources(), which links all the
> >> linkable resources (if not already linked).
> >>
> >> and platform_device_unlink_resources(), which unlinks all the
> >> resources.
> >
> > Who would call these functions, and why?
> >
> > And why have we never seen problems with removing platform devices
> > previously?
> >
>
> Have you tried removing devices that were created via DT and
> not using platform data?
Don't you think that answering two questions with another question as
something that isn't very helpful? :)
Dropped from my queue, please resend when you can provide the needed
information.
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-17 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 22:31 [PATCH] platform: Fix platform device resource linking Pantelis Antoniou
2013-01-03 22:40 ` Greg Kroah-Hartman
2013-01-03 22:43 ` Pantelis Antoniou
2013-01-17 16:31 ` Greg Kroah-Hartman [this message]
2013-01-17 16:50 ` Pantelis Antoniou
2013-01-17 17:07 ` Greg Kroah-Hartman
2013-01-17 17:27 ` Pantelis Antoniou
2013-01-18 3:00 ` Greg Kroah-Hartman
2013-01-18 9:05 ` Pantelis Antoniou
2013-01-18 19:47 ` Greg Kroah-Hartman
2013-01-18 19:52 ` Pantelis Antoniou
2013-02-08 22:02 ` Grant Likely
2013-02-11 17:18 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117163159.GD1396@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Russ.Dill@ti.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).