linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: comedi: addi_acpi_035: Fixed Camel Case Coding Style Issue
@ 2013-01-18  3:49 Jake Champlin
  2013-01-18  6:51 ` Dan Carpenter
  2013-01-18 20:44 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Jake Champlin @ 2013-01-18  3:49 UTC (permalink / raw)
  To: abbotti
  Cc: fmhess, gregkh, hsweeten, wfp5p, jake.champlin.27, devel,
	linux-kernel

Fixed camel case style issue.

Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
---
 drivers/staging/comedi/drivers/addi_apci_035.c | 34 +++++++++++++-------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_035.c b/drivers/staging/comedi/drivers/addi_apci_035.c
index c981d4b..e1c36d1 100644
--- a/drivers/staging/comedi/drivers/addi_apci_035.c
+++ b/drivers/staging/comedi/drivers/addi_apci_035.c
@@ -12,21 +12,21 @@
 
 static const struct addi_board apci035_boardtypes[] = {
 	{
-		.pc_DriverName		= "apci035",
-		.i_VendorId		= PCI_VENDOR_ID_ADDIDATA,
-		.i_DeviceId		= 0x0300,
-		.i_IorangeBase0		= 127,
-		.i_IorangeBase1		= APCI035_ADDRESS_RANGE,
-		.i_PCIEeprom		= 1,
-		.pc_EepromChip		= ADDIDATA_S5920,
-		.i_NbrAiChannel		= 16,
-		.i_NbrAiChannelDiff	= 8,
-		.i_AiChannelList	= 16,
-		.i_AiMaxdata		= 0xff,
-		.pr_AiRangelist		= &range_apci035_ai,
-		.i_Timer		= 1,
-		.ui_MinAcquisitiontimeNs = 10000,
-		.ui_MinDelaytimeNs	= 100000,
+		.pc_driver_name		= "apci035",
+		.vendor_id		= PCI_VENDOR_ID_ADDIDATA,
+		.device_id		= 0x0300,
+		.orange_base0		= 127,
+		.orange_base1		= APCI035_ADDRESS_RANGE,
+		.pci_eeprom		= 1,
+		.pc_eeprom_chip		= ADDIDATA_S5920,
+		.nbr_ai_channel		= 16,
+		.nbr_ai_channel_diff	= 8,
+		.ai_channel_list	= 16,
+		.ai_max_data		= 0xff,
+		.ai_range_list		= &range_apci035_ai,
+		.i_timer		= 1,
+		.ui_min_ack_time	= 10000,
+		.ui_min_delay_time	= 100000,
 		.interrupt		= v_APCI035_Interrupt,
 		.reset			= i_APCI035_Reset,
 		.ai_config		= i_APCI035_ConfigAnalogInput,
@@ -41,9 +41,9 @@ static struct comedi_driver apci035_driver = {
 	.driver_name	= "addi_apci_035",
 	.module		= THIS_MODULE,
 	.auto_attach	= addi_auto_attach,
-	.detach		= i_ADDI_Detach,
+	.detach		= addi_detach,
 	.num_names	= ARRAY_SIZE(apci035_boardtypes),
-	.board_name	= &apci035_boardtypes[0].pc_DriverName,
+	.board_name	= &apci035_boardtypes[0].pc_driver_name,
 	.offset		= sizeof(struct addi_board),
 };
 
-- 
1.8.1.1


-- 
Jake Champlin
jake.champlin.27@gmail.com
8123742937
<MuttClient>

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: comedi: addi_acpi_035: Fixed Camel Case Coding Style Issue
  2013-01-18  3:49 [PATCH] Staging: comedi: addi_acpi_035: Fixed Camel Case Coding Style Issue Jake Champlin
@ 2013-01-18  6:51 ` Dan Carpenter
  2013-01-18 20:44 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-01-18  6:51 UTC (permalink / raw)
  To: Jake Champlin; +Cc: abbotti, devel, fmhess, gregkh, linux-kernel, hsweeten

On Thu, Jan 17, 2013 at 10:49:36PM -0500, Jake Champlin wrote:
> Fixed camel case style issue.
> 

No.  That doesn't work at all.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: comedi: addi_acpi_035: Fixed Camel Case Coding Style Issue
  2013-01-18  3:49 [PATCH] Staging: comedi: addi_acpi_035: Fixed Camel Case Coding Style Issue Jake Champlin
  2013-01-18  6:51 ` Dan Carpenter
@ 2013-01-18 20:44 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-01-18 20:44 UTC (permalink / raw)
  To: Jake Champlin; +Cc: abbotti, fmhess, hsweeten, wfp5p, devel, linux-kernel

On Thu, Jan 17, 2013 at 10:49:36PM -0500, Jake Champlin wrote:
> Fixed camel case style issue.
> 
> Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
> ---
>  drivers/staging/comedi/drivers/addi_apci_035.c | 34 +++++++++++++-------------
>  1 file changed, 17 insertions(+), 17 deletions(-)

Did you even build the kernel with this patch applied?

I kind of doubt it...

Sorry, we can't accept this.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-18 20:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-18  3:49 [PATCH] Staging: comedi: addi_acpi_035: Fixed Camel Case Coding Style Issue Jake Champlin
2013-01-18  6:51 ` Dan Carpenter
2013-01-18 20:44 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).