* [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT
@ 2013-01-18 9:33 Michal Hocko
2013-01-18 21:39 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2013-01-18 9:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, Andrea Arcangeli, Mel Gorman, linux-kernel
CONFIG_PARAVIRT defines set_pmd_at only for CONFIG_TRANSPARENT_HUGEPAGE
which leads to the following compile errors when randconfig selected
CONFIG_NUMA_BALANCING && CONFIG_PARAVIRT && !CONFIG_TRANSPARENT_HUGEPAGE:
mm/mprotect.c: In function ‘change_pmd_protnuma’:
mm/mprotect.c:120: error: implicit declaration of function ‘set_pmd_at’
mm/memory.c: In function ‘do_pmd_numa_page’:
mm/memory.c:3529: error: implicit declaration of function ‘set_pmd_at’
Signed-off-by: Michal Hocko <mhocko@suse.cz>
---
arch/x86/include/asm/paravirt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index a0facf3..f551e89 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -528,7 +528,7 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte);
}
-#ifdef CONFIG_TRANSPARENT_HUGEPAGE
+#if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_NUMA_BALANCING)
static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
pmd_t *pmdp, pmd_t pmd)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT
2013-01-18 9:33 [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT Michal Hocko
@ 2013-01-18 21:39 ` Andrew Morton
2013-01-19 9:36 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2013-01-18 21:39 UTC (permalink / raw)
To: Michal Hocko; +Cc: linux-mm, Andrea Arcangeli, Mel Gorman, linux-kernel
On Fri, 18 Jan 2013 10:33:24 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> CONFIG_PARAVIRT defines set_pmd_at only for CONFIG_TRANSPARENT_HUGEPAGE
> which leads to the following compile errors when randconfig selected
> CONFIG_NUMA_BALANCING && CONFIG_PARAVIRT && !CONFIG_TRANSPARENT_HUGEPAGE:
>
> mm/mprotect.c: In function ___change_pmd_protnuma___:
> mm/mprotect.c:120: error: implicit declaration of function ___set_pmd_at___
>
> mm/memory.c: In function ___do_pmd_numa_page___:
> mm/memory.c:3529: error: implicit declaration of function ___set_pmd_at___
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
> arch/x86/include/asm/paravirt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
> index a0facf3..f551e89 100644
> --- a/arch/x86/include/asm/paravirt.h
> +++ b/arch/x86/include/asm/paravirt.h
> @@ -528,7 +528,7 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte);
> }
>
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_NUMA_BALANCING)
> static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
> pmd_t *pmdp, pmd_t pmd)
> {
Confused - there is no "#ifdef CONFIG_TRANSPARENT_HUGEPAGE" in there in
any kernel version I can think of.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT
2013-01-18 21:39 ` Andrew Morton
@ 2013-01-19 9:36 ` Michal Hocko
0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2013-01-19 9:36 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, Andrea Arcangeli, Mel Gorman, linux-kernel
On Fri 18-01-13 13:39:01, Andrew Morton wrote:
> On Fri, 18 Jan 2013 10:33:24 +0100
> Michal Hocko <mhocko@suse.cz> wrote:
>
> > CONFIG_PARAVIRT defines set_pmd_at only for CONFIG_TRANSPARENT_HUGEPAGE
> > which leads to the following compile errors when randconfig selected
> > CONFIG_NUMA_BALANCING && CONFIG_PARAVIRT && !CONFIG_TRANSPARENT_HUGEPAGE:
> >
> > mm/mprotect.c: In function ___change_pmd_protnuma___:
> > mm/mprotect.c:120: error: implicit declaration of function ___set_pmd_at___
> >
> > mm/memory.c: In function ___do_pmd_numa_page___:
> > mm/memory.c:3529: error: implicit declaration of function ___set_pmd_at___
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
> > ---
> > arch/x86/include/asm/paravirt.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
> > index a0facf3..f551e89 100644
> > --- a/arch/x86/include/asm/paravirt.h
> > +++ b/arch/x86/include/asm/paravirt.h
> > @@ -528,7 +528,7 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> > PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte);
> > }
> >
> > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_NUMA_BALANCING)
> > static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
> > pmd_t *pmdp, pmd_t pmd)
> > {
>
> Confused - there is no "#ifdef CONFIG_TRANSPARENT_HUGEPAGE" in there in
> any kernel version I can think of.
Ohh, I am missing c36e0501ee91d7616a188efbf9714b1fce150032 which didn't
go via your tree.
Sorry for the noise.
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-19 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-18 9:33 [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT Michal Hocko
2013-01-18 21:39 ` Andrew Morton
2013-01-19 9:36 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox